[PR #689] [MERGED] [stable32] chore: reorganize settings #699

Closed
opened 2026-02-26 06:31:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/689
Author: @backportbot[bot]
Created: 9/29/2025
Status: Merged
Merged: 9/29/2025
Merged by: @vitormattos

Base: stable32Head: backport/686/stable32


📝 Commits (10+)

  • 9d9c94c chore(refactor): move AppCOnfig spy to parent class
  • 5c8fa51 fix: namespace
  • 2b32dd0 fix: cs
  • 69859d5 fix: autoload
  • 46adbd2 chore: use templates to fix factory typing
  • fcdc95d chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object
  • bf0f351 fix: typo
  • e13bd36 fix: var name
  • 571d15e fix: use the field from settings
  • 8afdc6f fix: logic to get SMS provider

📊 Changes

58 files changed (+1254 additions, -531 deletions)

View changed files

📝 composer.json (+1 -0)
📝 lib/Command/Configure.php (+9 -8)
📝 lib/Command/Remove.php (+9 -15)
📝 lib/Command/Status.php (+2 -2)
📝 lib/Command/Test.php (+4 -4)
📝 lib/Provider/AFactory.php (+16 -15)
📝 lib/Provider/AProvider.php (+1 -1)
📝 lib/Provider/Channel/SMS/Factory.php (+14 -14)
📝 lib/Provider/Channel/SMS/Gateway.php (+31 -29)
📝 lib/Provider/Channel/SMS/Provider/AProvider.php (+14 -3)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php (+19 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php (+23 -9)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php (+20 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php (+35 -11)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php (+27 -10)
📝 lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php (+19 -7)

...and 38 more files

📄 Description

Backport of PR #686


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/689 **Author:** [@backportbot[bot]](https://github.com/apps/backportbot) **Created:** 9/29/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@vitormattos](https://github.com/vitormattos) **Base:** `stable32` ← **Head:** `backport/686/stable32` --- ### 📝 Commits (10+) - [`9d9c94c`](https://github.com/nextcloud/twofactor_gateway/commit/9d9c94c7cea8f3dec9242c642b075e27558563b6) chore(refactor): move AppCOnfig spy to parent class - [`5c8fa51`](https://github.com/nextcloud/twofactor_gateway/commit/5c8fa5129581a0d8c476d221c6445ce1052a2bee) fix: namespace - [`2b32dd0`](https://github.com/nextcloud/twofactor_gateway/commit/2b32dd026d13844be707fc5153688881123d0aa5) fix: cs - [`69859d5`](https://github.com/nextcloud/twofactor_gateway/commit/69859d54b25550341d4dd998ed6aee81c85c2d6b) fix: autoload - [`46adbd2`](https://github.com/nextcloud/twofactor_gateway/commit/46adbd2f5d8887d180e53eb00314d086e5a9852b) chore: use templates to fix factory typing - [`fcdc95d`](https://github.com/nextcloud/twofactor_gateway/commit/fcdc95d3989ee48f9b859a23f963eb4531bf543a) chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object - [`bf0f351`](https://github.com/nextcloud/twofactor_gateway/commit/bf0f3514a7479be6830ec12f8cbb5765a3d35bab) fix: typo - [`e13bd36`](https://github.com/nextcloud/twofactor_gateway/commit/e13bd365b9e2b874cd2d029b091ce63848c90b31) fix: var name - [`571d15e`](https://github.com/nextcloud/twofactor_gateway/commit/571d15e79f647e45c3a9a176ad2e2cd28aa1507d) fix: use the field from settings - [`8afdc6f`](https://github.com/nextcloud/twofactor_gateway/commit/8afdc6f7f2c8d991921889a8de3c72fb70633913) fix: logic to get SMS provider ### 📊 Changes **58 files changed** (+1254 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -0) 📝 `lib/Command/Configure.php` (+9 -8) 📝 `lib/Command/Remove.php` (+9 -15) 📝 `lib/Command/Status.php` (+2 -2) 📝 `lib/Command/Test.php` (+4 -4) 📝 `lib/Provider/AFactory.php` (+16 -15) 📝 `lib/Provider/AProvider.php` (+1 -1) 📝 `lib/Provider/Channel/SMS/Factory.php` (+14 -14) 📝 `lib/Provider/Channel/SMS/Gateway.php` (+31 -29) 📝 `lib/Provider/Channel/SMS/Provider/AProvider.php` (+14 -3) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php` (+19 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php` (+23 -9) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php` (+20 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php` (+35 -11) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php` (+27 -10) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php` (+19 -7) _...and 38 more files_ </details> ### 📄 Description Backport of PR #686 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 06:31:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/twofactor_gateway-nextcloud#699
No description provided.