[PR #690] [MERGED] [stable31] chore: reorganize settings #698

New issue

Closed

opened 2026-02-26 06:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/690
Author: @backportbot[bot]
Created: 9/29/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @vitormattos

Base: stable31 ← Head: backport/686/stable31

📝 Commits (10+)

d7a4465 chore(refactor): move AppCOnfig spy to parent class
44fd8d0 fix: namespace
01e114a fix: cs
54ec108 fix: autoload
4868de9 chore: use templates to fix factory typing
c6453fb chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object
50853c4 fix: typo
10ba72c fix: var name
1788b08 fix: use the field from settings
76f0b04 fix: logic to get SMS provider

📊 Changes

58 files changed (+1254 additions, -531 deletions)

View changed files

📝 composer.json (+1 -0)
📝 lib/Command/Configure.php (+9 -8)
📝 lib/Command/Remove.php (+9 -15)
📝 lib/Command/Status.php (+2 -2)
📝 lib/Command/Test.php (+4 -4)
📝 lib/Provider/AFactory.php (+16 -15)
📝 lib/Provider/AProvider.php (+1 -1)
📝 lib/Provider/Channel/SMS/Factory.php (+14 -14)
📝 lib/Provider/Channel/SMS/Gateway.php (+31 -29)
📝 lib/Provider/Channel/SMS/Provider/AProvider.php (+14 -3)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php (+19 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php (+23 -9)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php (+20 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php (+35 -11)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php (+27 -10)
📝 lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php (+19 -7)

...and 38 more files

📄 Description

Backport of #686

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

Review and resolve any conflicts
Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/690 **Author:** [@backportbot[bot]](https://github.com/apps/backportbot) **Created:** 9/29/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@vitormattos](https://github.com/vitormattos) **Base:** `stable31` ← **Head:** `backport/686/stable31` --- ### 📝 Commits (10+) - [`d7a4465`](https://github.com/nextcloud/twofactor_gateway/commit/d7a4465a4859f926d346677c1b7a6e1ee5ce3602) chore(refactor): move AppCOnfig spy to parent class - [`44fd8d0`](https://github.com/nextcloud/twofactor_gateway/commit/44fd8d086268a738e8f2f8221ff47a0ebdcc5039) fix: namespace - [`01e114a`](https://github.com/nextcloud/twofactor_gateway/commit/01e114ad48691b72c2a7e0f8d1fb2cfc90685840) fix: cs - [`54ec108`](https://github.com/nextcloud/twofactor_gateway/commit/54ec1085a5bdbbe8387c30e5153ab8a917501c7b) fix: autoload - [`4868de9`](https://github.com/nextcloud/twofactor_gateway/commit/4868de9e4afa677487fa6d44eb91aa90f6504fa8) chore: use templates to fix factory typing - [`c6453fb`](https://github.com/nextcloud/twofactor_gateway/commit/c6453fb9778a0ba04eac5cf64913ce2ee37edbd9) chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object - [`50853c4`](https://github.com/nextcloud/twofactor_gateway/commit/50853c42c922df8dafd55c52f5403ac9bd035d40) fix: typo - [`10ba72c`](https://github.com/nextcloud/twofactor_gateway/commit/10ba72c5217b6d81d13d57c041229cb68051527c) fix: var name - [`1788b08`](https://github.com/nextcloud/twofactor_gateway/commit/1788b08d36a58a8a369ba2a4de09e2bc29619b40) fix: use the field from settings - [`76f0b04`](https://github.com/nextcloud/twofactor_gateway/commit/76f0b04b33747ff328ff61b7cd39c3798c70c8fa) fix: logic to get SMS provider ### 📊 Changes **58 files changed** (+1254 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -0) 📝 `lib/Command/Configure.php` (+9 -8) 📝 `lib/Command/Remove.php` (+9 -15) 📝 `lib/Command/Status.php` (+2 -2) 📝 `lib/Command/Test.php` (+4 -4) 📝 `lib/Provider/AFactory.php` (+16 -15) 📝 `lib/Provider/AProvider.php` (+1 -1) 📝 `lib/Provider/Channel/SMS/Factory.php` (+14 -14) 📝 `lib/Provider/Channel/SMS/Gateway.php` (+31 -29) 📝 `lib/Provider/Channel/SMS/Provider/AProvider.php` (+14 -3) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php` (+19 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php` (+23 -9) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php` (+20 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php` (+35 -11) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php` (+27 -10) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php` (+19 -7) _...and 38 more files_ </details> ### 📄 Description Backport of #686 Warning, This backport's changes differ from the original and might be incomplete ⚠️ ## Todo - [x] Review and resolve any conflicts - [x] Amend HEAD commit to remove the line stating to skip CI --- Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 06:31:52 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 06:31:54 +03:00

[PR #698] [MERGED] [stable31] fix: scoper implementation #705

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#698

No description provided.

Rows
Columns