[PR #686] [MERGED] chore: reorganize settings #697

New issue

Closed

opened 2026-02-26 06:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/686
Author: @vitormattos
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @vitormattos

Base: master ← Head: chore/reorganize-settings

📝 Commits (10+)

32f2b67 chore(refactor): move AppCOnfig spy to parent class
b479530 fix: namespace
2000fbb fix: cs
32ebf22 fix: autoload
d196a00 chore: use templates to fix factory typing
19e96cc chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object
2d5be24 fix: typo
4972606 fix: var name
9aaedea fix: use the field from settings
7c90fed fix: logic to get SMS provider

📊 Changes

58 files changed (+1254 additions, -531 deletions)

View changed files

📝 composer.json (+1 -0)
📝 lib/Command/Configure.php (+9 -8)
📝 lib/Command/Remove.php (+9 -15)
📝 lib/Command/Status.php (+2 -2)
📝 lib/Command/Test.php (+4 -4)
📝 lib/Provider/AFactory.php (+16 -15)
📝 lib/Provider/AProvider.php (+1 -1)
📝 lib/Provider/Channel/SMS/Factory.php (+14 -14)
📝 lib/Provider/Channel/SMS/Gateway.php (+31 -29)
📝 lib/Provider/Channel/SMS/Provider/AProvider.php (+14 -3)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php (+19 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php (+23 -9)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php (+20 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php (+16 -7)
📝 lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php (+35 -11)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php (+23 -8)
📝 lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php (+27 -10)
📝 lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php (+19 -7)

...and 38 more files

📄 Description

WIP

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/686 **Author:** [@vitormattos](https://github.com/vitormattos) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@vitormattos](https://github.com/vitormattos) **Base:** `master` ← **Head:** `chore/reorganize-settings` --- ### 📝 Commits (10+) - [`32f2b67`](https://github.com/nextcloud/twofactor_gateway/commit/32f2b67fd287e033e652f292b3ef2508137df677) chore(refactor): move AppCOnfig spy to parent class - [`b479530`](https://github.com/nextcloud/twofactor_gateway/commit/b479530e06d6d6b3761f3bb293e7e6abd7586f35) fix: namespace - [`2000fbb`](https://github.com/nextcloud/twofactor_gateway/commit/2000fbb730de865a996bffee8bc09e5404fe703d) fix: cs - [`32ebf22`](https://github.com/nextcloud/twofactor_gateway/commit/32ebf221fea8b784354ef5428db6fee255839248) fix: autoload - [`d196a00`](https://github.com/nextcloud/twofactor_gateway/commit/d196a0062ee7a0874434ff88499b66fde90871e2) chore: use templates to fix factory typing - [`19e96cc`](https://github.com/nextcloud/twofactor_gateway/commit/19e96cc8750fecf7f2fed2fb0abf6fcdfe4eed0b) chore(refactor): convert SCHEMA constant to a DTO - Data Transfer Object - [`2d5be24`](https://github.com/nextcloud/twofactor_gateway/commit/2d5be24576a17724156754e1fe69f5c9f8db3f64) fix: typo - [`4972606`](https://github.com/nextcloud/twofactor_gateway/commit/4972606fbd0b0565b126c458afef12eb81b827d1) fix: var name - [`9aaedea`](https://github.com/nextcloud/twofactor_gateway/commit/9aaedeafaac3250481109529d85519376ecca852) fix: use the field from settings - [`7c90fed`](https://github.com/nextcloud/twofactor_gateway/commit/7c90fedcfe90c977a83d88caa68a76c914789486) fix: logic to get SMS provider ### 📊 Changes **58 files changed** (+1254 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -0) 📝 `lib/Command/Configure.php` (+9 -8) 📝 `lib/Command/Remove.php` (+9 -15) 📝 `lib/Command/Status.php` (+2 -2) 📝 `lib/Command/Test.php` (+4 -4) 📝 `lib/Provider/AFactory.php` (+16 -15) 📝 `lib/Provider/AProvider.php` (+1 -1) 📝 `lib/Provider/Channel/SMS/Factory.php` (+14 -14) 📝 `lib/Provider/Channel/SMS/Gateway.php` (+31 -29) 📝 `lib/Provider/Channel/SMS/Provider/AProvider.php` (+14 -3) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickSend.php` (+19 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellCentral.php` (+23 -9) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClickatellPortal.php` (+20 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/ClockworkSMS.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/EcallSMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/HuaweiE3531.php` (+16 -7) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/Ovh.php` (+35 -11) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PlaySMS.php` (+23 -8) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/PuzzelSMS.php` (+27 -10) 📝 `lib/Provider/Channel/SMS/Provider/Drivers/SMSApi.php` (+19 -7) _...and 38 more files_ </details> ### 📄 Description WIP --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>