mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 09:05:55 +03:00
[PR #668] [MERGED] Support the native RPC-JSON protocol of the signal-cli package #678
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#678
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nextcloud/twofactor_gateway/pull/668
Author: @rotdrop
Created: 9/23/2025
Status: ✅ Merged
Merged: 9/23/2025
Merged by: @vitormattos
Base:
master← Head:feature/signal-cli📝 Commits (2)
f692c78Signal: make it work with native JSON-RPC endpoints of the signal cli package.d510067Polish the signal section of the documentation.📊 Changes
2 files changed (+127 additions, -30 deletions)
View changed files
📝
doc/Admin Documentation.md(+15 -3)📝
lib/Provider/Channel/Signal/Gateway.php(+112 -27)📄 Description
The currently used protocols are partly outdated and refer to
https://gitlab.com/morph027/signal-cli-dbus-rest-api
https://gitlab.com/morph027/python-signal-cli-rest-api
which are considered obsolete by its author in favour of the the JSON-RPC interface of the signal-cli package.
There is also another Docker project
https://github.com/bbernhard/signal-cli-rest-api
which seemingly uses the API used by the obsolete "morph027" packages. However, as signal-cli already supports a remote API: why not use it, instead of having to install yet another package?
The old APIs including bbernhard are still supported though, just that the Signal-gateway first tries the native remote protocol of signal-cli and if that does not work out it falls back to what it did without this commit.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.