mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 09:05:55 +03:00
[GH-ISSUE #274] RFE: use name from theming in authentication code message #63
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#63
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @putt1ck on GitHub (Aug 29, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/274
In a world of phishers, it seems sensible to ensure the messages sent by a system are not generic, especially when we train people to be suspicious of messages. So if we can use the "name" element from the NC theming in the message sent to the user this increases its trust level.
So in the Signal message it currently reads "123654 is your Nextcloud authentication code" and with this enhancement it would read "123654 is your My Site Name authentication code"
@ChristophWurst commented on GitHub (Aug 29, 2019):
Yes! I've briefly mentioned this at https://github.com/nextcloud/twofactor_gateway/pull/253#discussion_r308589512 but we should indeed do this!
The only concern right now is that theming isn't properly exposed via a public API in the Nextcloud server. But I'll open a ticket for it if it doesn't already exist.
@ChristophWurst commented on GitHub (Aug 29, 2019):
https://github.com/nextcloud/server/issues/15815 was the ticket