[PR #579] [CLOSED] Feature/use signal cli json rpc #599

New issue

Closed

opened 2026-02-26 06:31:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:31:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/579
Author: @rotdrop
Created: 6/19/2023
Status: ❌ Closed

Base: master ← Head: feature/use-signal-cli-json-rpc

📝 Commits (4)

05732e2 Fix "81ee6f9 N Fri May 12.. Vitor..Fix codes that lint:fix can't fix"
b223159 Support https://gitlab.com/morph027/python-signal-cli-rest-api in addition to the deprectated https://gitlab.com/morph027/signal-cli-dbus-rest-api.
92442e0 Signal: use native signal-cli JSON RPC by default.
9bda470 Polish the signal section of the documentation.

📊 Changes

7 files changed (+129 additions, -36 deletions)

View changed files

📝 doc/Admin Documentation.md (+13 -3)
📝 lib/Command/Configure.php (+9 -4)
📝 lib/Provider/AProvider.php (+1 -0)
📝 lib/Service/Gateway/Signal/Gateway.php (+93 -27)
📝 lib/Service/Gateway/Signal/GatewayConfig.php (+9 -0)
📝 src/components/GatewaySettings.vue (+2 -2)
📝 src/main.js (+2 -0)

📄 Description

signal-cli comes with its own HTTP endpoint for JSON RPC calls since signal-cli 0.11.5.

This means that there is no longer a need for any intermediate wrappe, so lets just use the native HTTP endpoint of Signal-Cli.

The old methods are tried in turn if the native end-point is not reachable.

This PR maybe also fixes #573.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/579 **Author:** [@rotdrop](https://github.com/rotdrop) **Created:** 6/19/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/use-signal-cli-json-rpc` --- ### 📝 Commits (4) - [`05732e2`](https://github.com/nextcloud/twofactor_gateway/commit/05732e204d86efa3ce5e383454735b279207f8a4) Fix "81ee6f9 N Fri May 12.. Vitor..Fix codes that lint:fix can't fix" - [`b223159`](https://github.com/nextcloud/twofactor_gateway/commit/b2231592a24291b0074f7429df954bbe633e03ad) Support https://gitlab.com/morph027/python-signal-cli-rest-api in addition to the deprectated https://gitlab.com/morph027/signal-cli-dbus-rest-api. - [`92442e0`](https://github.com/nextcloud/twofactor_gateway/commit/92442e08733f2eb7a9baf3d0626e571216b98a49) Signal: use native signal-cli JSON RPC by default. - [`9bda470`](https://github.com/nextcloud/twofactor_gateway/commit/9bda47033f39b2e8b7f9d69d814b0ee34b85c26d) Polish the signal section of the documentation. ### 📊 Changes **7 files changed** (+129 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `doc/Admin Documentation.md` (+13 -3) 📝 `lib/Command/Configure.php` (+9 -4) 📝 `lib/Provider/AProvider.php` (+1 -0) 📝 `lib/Service/Gateway/Signal/Gateway.php` (+93 -27) 📝 `lib/Service/Gateway/Signal/GatewayConfig.php` (+9 -0) 📝 `src/components/GatewaySettings.vue` (+2 -2) 📝 `src/main.js` (+2 -0) </details> ### 📄 Description [signal-cli](https://github.com/AsamK/signal-cli) comes with its own HTTP endpoint for JSON RPC calls since [signal-cli 0.11.5](https://github.com/AsamK/signal-cli/blob/master/CHANGELOG.md#0115---2022-11-07). This means that there is no longer a need for any intermediate wrappe, so lets just use the native HTTP endpoint of Signal-Cli. The old methods are tried in turn if the native end-point is not reachable. This PR maybe also fixes #573. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>