starred/twofactor_gateway-nextcloud

Fork 0

mirror of https://github.com/nextcloud/twofactor_gateway.git synced 2026-04-25 17:15:53 +03:00

[PR #575] [CLOSED] Fix "`81ee6f9` N Fri May 12.. Vitor..Fix codes that lint:fix can't fix" #595

New issue

Closed

opened 2026-02-26 06:31:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:31:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/575
Author: @rotdrop
Created: 6/16/2023
Status: ❌ Closed

Base: master ← Head: bugfix/fix-fix-code-that-lint-cant-fix

📝 Commits (1)

e18bcc4 Fix "81ee6f9 N Fri May 12.. Vitor..Fix codes that lint:fix can't fix"

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 src/components/GatewaySettings.vue (+2 -2)
📝 src/main.js (+2 -0)

📄 Description

So 81ee6f9 actually broke the setup code in the user preferences. This PR addresses the following two things:

prior to 81ee6f9 the "isAvailable" status, see

github.com/nextcloud/twofactor_gateway@60ec37b508/src/components/GatewaySettings.vue (L76)

was not retrieved from the data-response, but was the success status of the AJAX call, see

github.com/nextcloud/twofactor_gateway@e8bc3a2549/src/service/registration.js (L12-L17)

further, it corrects the incorrect parens here (gateway param must be passed to the url-generator, not to axios):

github.com/nextcloud/twofactor_gateway@60ec37b508/src/components/GatewaySettings.vue (L112-L114)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/575 **Author:** [@rotdrop](https://github.com/rotdrop) **Created:** 6/16/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/fix-fix-code-that-lint-cant-fix` --- ### 📝 Commits (1) - [`e18bcc4`](https://github.com/nextcloud/twofactor_gateway/commit/e18bcc4a7984fc2f4fd50af0a36a5cbd2d0b510a) Fix "81ee6f9 N Fri May 12.. Vitor..Fix codes that lint:fix can't fix" ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/components/GatewaySettings.vue` (+2 -2) 📝 `src/main.js` (+2 -0) </details> ### 📄 Description So 81ee6f9 actually broke the setup code in the user preferences. This PR addresses the following two things: - prior to 81ee6f9 the "isAvailable" status, see https://github.com/nextcloud/twofactor_gateway/blob/60ec37b5085c203adaf95cc56a7d0228d06a8c8b/src/components/GatewaySettings.vue#L76 was not retrieved from the data-response, but was the success status of the AJAX call, see https://github.com/nextcloud/twofactor_gateway/blob/e8bc3a25492e962d047f5929ed342ea93d759484/src/service/registration.js#L12-L17 - further, it corrects the incorrect parens here (gateway param must be passed to the url-generator, not to axios): https://github.com/nextcloud/twofactor_gateway/blob/60ec37b5085c203adaf95cc56a7d0228d06a8c8b/src/components/GatewaySettings.vue#L112-L114 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 06:31:34 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 06:31:36 +03:00

[PR #595] [CLOSED] Chore(deps): Bump @nextcloud/router from 2.1.1 to 2.2.0 #611

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#595

No description provided.

Rows
Columns

[PR #575] [CLOSED] Fix "81ee6f9 N Fri May 12.. Vitor..Fix codes that lint:fix can't fix" #595

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #575] [CLOSED] Fix "`81ee6f9` N Fri May 12.. Vitor..Fix codes that lint:fix can't fix" #595