starred/twofactor_gateway-nextcloud

Fork 0

mirror of https://github.com/nextcloud/twofactor_gateway.git synced 2026-04-25 09:05:55 +03:00

[GH-ISSUE #209] Add SMS Central (Australia) gateway support #51

New issue

Open

opened 2026-02-26 05:32:42 +03:00 by kerem · 7 comments

kerem commented

2026-02-26 05:32:42 +03:00

Owner

Originally created by @Ekwok95 on GitHub (Feb 27, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/209

Hello,
I would like to add a new SMS gateway to this application. What should I do in order to achieve this?

Originally created by @Ekwok95 on GitHub (Feb 27, 2019). Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/209 Hello, I would like to add a new SMS gateway to this application. What should I do in order to achieve this?

kerem added the

enhancement

1. to develop

labels

2026-02-26 05:32:42 +03:00

kerem commented

2026-02-26 05:32:42 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Feb 27, 2019):

How custom is it? Did you write it yourself?

If it's usable for other users as well I'd suggest to add this as new SMS gateway implementation. Otherwise you'll probably have to fork this app and adjust it there.

@ChristophWurst commented on GitHub (Feb 27, 2019): How custom is it? Did you write it yourself? If it's usable for other users as well I'd suggest to add this as new SMS gateway implementation. Otherwise you'll probably have to fork this app and adjust it there.

kerem commented

2026-02-26 05:32:42 +03:00

Author

Owner

@Ekwok95 commented on GitHub (Feb 27, 2019):

I see. In that case I would like for the SMS gateway SMS Central (Australia) to be added as an SMS gateway implementation. This SMS gateway was not written by me but due to the limited options not being able to work for Australian numbers, I needed to find a way to add this option into this application. Apologies for not being specific with my request.

@Ekwok95 commented on GitHub (Feb 27, 2019): I see. In that case I would like for the SMS gateway SMS Central (Australia) to be added as an SMS gateway implementation. This SMS gateway was not written by me but due to the limited options not being able to work for Australian numbers, I needed to find a way to add this option into this application. Apologies for not being specific with my request.

kerem commented

2026-02-26 05:32:42 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Feb 28, 2019):

Then I'd suggest we add this to our code base :)

Have a look at PRs like https://github.com/nextcloud/twofactor_gateway/pull/185 and https://github.com/nextcloud/twofactor_gateway/pull/169. I think it should be clear about what you have to change. Once you have some code please open a pull request and I can help you put the code into shape :)

@ChristophWurst commented on GitHub (Feb 28, 2019): Then I'd suggest we add this to our code base :) Have a look at PRs like https://github.com/nextcloud/twofactor_gateway/pull/185 and https://github.com/nextcloud/twofactor_gateway/pull/169. I think it should be clear about what you have to change. Once you have some code please open a pull request and I can help you put the code into shape :)

kerem commented

2026-02-26 05:32:42 +03:00

Author

Owner

@Ekwok95 commented on GitHub (Feb 28, 2019):

Cool thanks. I'll get started on this.

@Ekwok95 commented on GitHub (Feb 28, 2019): Cool thanks. I'll get started on this.

kerem commented

2026-02-26 05:32:43 +03:00

Author

Owner

@Ekwok95 commented on GitHub (Mar 1, 2019):

Hey Chris, for the Config.php file for the provider, and the provider.php files seem like they are taking in values for API POST requests. Am I right? According to SMSCentral API documentation, it seems that 5 type of values are needed to be sent to the URL for the API calls. I'm not sure where to include these values in those 2 files.

The 5 parameters are as follows:

USERNAME
PASSWORD
ACTION - I believe this only requires one value which is 'send' from what I read in the API documentation.
RECIPIENT
MESSAGE_TEXT

@Ekwok95 commented on GitHub (Mar 1, 2019): Hey Chris, for the Config.php file for the provider, and the provider.php files seem like they are taking in values for API POST requests. Am I right? According to SMSCentral API documentation, it seems that 5 type of values are needed to be sent to the URL for the API calls. I'm not sure where to include these values in those 2 files. The 5 parameters are as follows: - USERNAME - PASSWORD - ACTION - I believe this only requires one value which is 'send' from what I read in the API documentation. - RECIPIENT - MESSAGE_TEXT

kerem commented

2026-02-26 05:32:43 +03:00

Author

Owner

@Ekwok95 commented on GitHub (Mar 1, 2019):

Also, this is the first time I've used Github to commit code to someone else's application. How do I upload the code here or send it here for review?

@Ekwok95 commented on GitHub (Mar 1, 2019): Also, this is the first time I've used Github to commit code to someone else's application. How do I upload the code here or send it here for review?

kerem commented

2026-02-26 05:32:43 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Mar 1, 2019):

Looks like username and password go into the provider config class, action is static and recipient and text get passed into the gateway just like with the other implementations.

The workflow is that you create your fork, create a new branch, commit to that branch, push it back to github and open a pull request here. I think this is well documented on GitHub's help pages: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

@ChristophWurst commented on GitHub (Mar 1, 2019): Looks like username and password go into the provider config class, action is static and recipient and text get passed into the gateway just like with the other implementations. The workflow is that you create your fork, create a new branch, commit to that branch, push it back to github and open a pull request here. I think this is well documented on GitHub's help pages: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

kerem referenced this issue

2026-02-26 05:33:50 +03:00

[PR #60] [MERGED] Document Signal gateway configuration #178

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#51

No description provided.

Rows
Columns