mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 00:55:52 +03:00
[GH-ISSUE #200] The writing of the app name should be aligned with other existing 2FA apps #50
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#50
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @j-ed on GitHub (Feb 12, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/200
Several different 2FA apps already exist for Nextcloud, like "Two Factor TOTP", "Two Factor U2F".
Therefore the writing of the app name should be aligned accordingly. I would recommend to rename it
to "Two Factor Gateway" (without a dash) instead of "Two-Factor Gateway".
@ChristophWurst commented on GitHub (Feb 12, 2019):
Actually, Two-Factor is the correct spelling. This should be fixed at
github.com/nextcloud/twofactor_u2f@09f10b5dfc/appinfo/info.xml (L4)andgithub.com/nextcloud/twofactor_totp@46dc96bbf4/appinfo/info.xml (L5). Could you send a pull request? :)@j-ed commented on GitHub (Feb 12, 2019):
@ChristophWurst [x] pull requests created.
@ChristophWurst commented on GitHub (Feb 12, 2019):
Thank you!