[PR #352] Add Plivo as SMS Provider #411

Open
opened 2026-02-26 06:30:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/352
Author: @cdjenkins
Created: 5/31/2020
Status: 🔄 Open

Base: masterHead: master


📝 Commits (10+)

  • dab96f0 1st draft impl of Plivo SMS provider
  • 6545e7e finish Plivo implementation
  • 2d44d85 fix compilation issues
  • 8cd0c96 add plivo to documentation
  • d22c44d fix indentation. sort providers alphabetically.
  • 0e99191 improve use of variable inside string
  • 83cb8b4 fix bug. referenced const array incorrectly
  • 16c9729 fix bug. calling wrong functions
  • 209cb8a add logger. post doesn't work, but get does on IClient
  • f126375 fix bug. don't pass 'url' param to plivo unless you have a valid url

📊 Changes

5 files changed (+221 additions, -2 deletions)

View changed files

📝 doc/Admin Documentation.md (+11 -0)
📝 lib/Command/Configure.php (+41 -2)
lib/Service/Gateway/SMS/Provider/Plivo.php (+91 -0)
lib/Service/Gateway/SMS/Provider/PlivoConfig.php (+76 -0)
📝 lib/Service/Gateway/SMS/Provider/ProviderFactory.php (+2 -0)

📄 Description

@ChristophWurst @MorrisJobke @boppy @killerbees19

Added code to use Plivo as a SMS Provider.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/352 **Author:** [@cdjenkins](https://github.com/cdjenkins) **Created:** 5/31/2020 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`dab96f0`](https://github.com/nextcloud/twofactor_gateway/commit/dab96f04407649fca90d0eee62d08f2595175e84) 1st draft impl of Plivo SMS provider - [`6545e7e`](https://github.com/nextcloud/twofactor_gateway/commit/6545e7eb9f6b9d2b8f20991c1a6e01779c01f1da) finish Plivo implementation - [`2d44d85`](https://github.com/nextcloud/twofactor_gateway/commit/2d44d8525d97809b20837f7771abb56ab774d90f) fix compilation issues - [`8cd0c96`](https://github.com/nextcloud/twofactor_gateway/commit/8cd0c96319da870d1904150ec521907db9efaaa4) add plivo to documentation - [`d22c44d`](https://github.com/nextcloud/twofactor_gateway/commit/d22c44de03fa157a6bcdccd6ce255d92ee2e75a3) fix indentation. sort providers alphabetically. - [`0e99191`](https://github.com/nextcloud/twofactor_gateway/commit/0e9919184425c57d6935c95fa5803d8d89286b43) improve use of variable inside string - [`83cb8b4`](https://github.com/nextcloud/twofactor_gateway/commit/83cb8b4a180580b178b08e6a055cdc83c1794c67) fix bug. referenced const array incorrectly - [`16c9729`](https://github.com/nextcloud/twofactor_gateway/commit/16c9729d2d4a451958d8f51a180807856272b1a8) fix bug. calling wrong functions - [`209cb8a`](https://github.com/nextcloud/twofactor_gateway/commit/209cb8a5e72f1a1689d2c774341839eda25d488d) add logger. post doesn't work, but get does on IClient - [`f126375`](https://github.com/nextcloud/twofactor_gateway/commit/f1263750349b0ef0ecdc2b4dabc66b0204dae94e) fix bug. don't pass 'url' param to plivo unless you have a valid url ### 📊 Changes **5 files changed** (+221 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `doc/Admin Documentation.md` (+11 -0) 📝 `lib/Command/Configure.php` (+41 -2) ➕ `lib/Service/Gateway/SMS/Provider/Plivo.php` (+91 -0) ➕ `lib/Service/Gateway/SMS/Provider/PlivoConfig.php` (+76 -0) 📝 `lib/Service/Gateway/SMS/Provider/ProviderFactory.php` (+2 -0) </details> ### 📄 Description @ChristophWurst @MorrisJobke @boppy @killerbees19 Added code to use Plivo as a SMS Provider. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/twofactor_gateway-nextcloud#411
No description provided.