[PR #340] [MERGED] Allow Gateway Removal from OCC CLI #403

Closed
opened 2026-02-26 06:30:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/340
Author: @simonspa
Created: 4/17/2020
Status: Merged
Merged: 5/27/2020
Merged by: @ChristophWurst

Base: masterHead: removal


📝 Commits (1)

  • bb0eb83 Allow removing gateways via CLI

📊 Changes

16 files changed (+250 additions, -69 deletions)

View changed files

📝 appinfo/info.xml (+1 -0)
lib/Command/Remove.php (+85 -0)
📝 lib/Service/Gateway/SMS/GatewayConfig.php (+4 -0)
📝 lib/Service/Gateway/SMS/Provider/ClickatellCentralConfig.php (+13 -6)
📝 lib/Service/Gateway/SMS/Provider/ClockworkSMSConfig.php (+11 -4)
📝 lib/Service/Gateway/SMS/Provider/EcallSMSConfig.php (+13 -6)
📝 lib/Service/Gateway/SMS/Provider/HuaweiE3531Config.php (+11 -4)
📝 lib/Service/Gateway/SMS/Provider/OvhConfig.php (+16 -9)
📝 lib/Service/Gateway/SMS/Provider/PlaySMSConfig.php (+13 -6)
📝 lib/Service/Gateway/SMS/Provider/PuzzelSMSConfig.php (+14 -7)
📝 lib/Service/Gateway/SMS/Provider/Sms77IoConfig.php (+11 -4)
📝 lib/Service/Gateway/SMS/Provider/SpryngSMSConfig.php (+11 -4)
📝 lib/Service/Gateway/SMS/Provider/VoipMsConfig.php (+13 -6)
📝 lib/Service/Gateway/SMS/Provider/WebSmsConfig.php (+12 -5)
📝 lib/Service/Gateway/Signal/GatewayConfig.php (+11 -4)
📝 lib/Service/Gateway/Telegram/GatewayConfig.php (+11 -4)

📄 Description

This fixes #331 - adds a twofactorauth:gateway:remove command to the OCC CLI.

@ChristophWurst I was wondering if it wouldn't make sense to move some functions of the gateway (-provider) in a parent class since they are very much the same everywhere.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/340 **Author:** [@simonspa](https://github.com/simonspa) **Created:** 4/17/2020 **Status:** ✅ Merged **Merged:** 5/27/2020 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `removal` --- ### 📝 Commits (1) - [`bb0eb83`](https://github.com/nextcloud/twofactor_gateway/commit/bb0eb8308488312572972a3c6c44e9d1f3953cf0) Allow removing gateways via CLI ### 📊 Changes **16 files changed** (+250 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `appinfo/info.xml` (+1 -0) ➕ `lib/Command/Remove.php` (+85 -0) 📝 `lib/Service/Gateway/SMS/GatewayConfig.php` (+4 -0) 📝 `lib/Service/Gateway/SMS/Provider/ClickatellCentralConfig.php` (+13 -6) 📝 `lib/Service/Gateway/SMS/Provider/ClockworkSMSConfig.php` (+11 -4) 📝 `lib/Service/Gateway/SMS/Provider/EcallSMSConfig.php` (+13 -6) 📝 `lib/Service/Gateway/SMS/Provider/HuaweiE3531Config.php` (+11 -4) 📝 `lib/Service/Gateway/SMS/Provider/OvhConfig.php` (+16 -9) 📝 `lib/Service/Gateway/SMS/Provider/PlaySMSConfig.php` (+13 -6) 📝 `lib/Service/Gateway/SMS/Provider/PuzzelSMSConfig.php` (+14 -7) 📝 `lib/Service/Gateway/SMS/Provider/Sms77IoConfig.php` (+11 -4) 📝 `lib/Service/Gateway/SMS/Provider/SpryngSMSConfig.php` (+11 -4) 📝 `lib/Service/Gateway/SMS/Provider/VoipMsConfig.php` (+13 -6) 📝 `lib/Service/Gateway/SMS/Provider/WebSmsConfig.php` (+12 -5) 📝 `lib/Service/Gateway/Signal/GatewayConfig.php` (+11 -4) 📝 `lib/Service/Gateway/Telegram/GatewayConfig.php` (+11 -4) </details> ### 📄 Description This fixes #331 - adds a `twofactorauth:gateway:remove` command to the OCC CLI. @ChristophWurst I was wondering if it wouldn't make sense to move some functions of the gateway (-provider) in a parent class since they are very much the same everywhere. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 06:30:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/twofactor_gateway-nextcloud#403
No description provided.