mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 17:15:53 +03:00
[PR #340] [MERGED] Allow Gateway Removal from OCC CLI #403
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#403
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nextcloud/twofactor_gateway/pull/340
Author: @simonspa
Created: 4/17/2020
Status: ✅ Merged
Merged: 5/27/2020
Merged by: @ChristophWurst
Base:
master← Head:removal📝 Commits (1)
bb0eb83Allow removing gateways via CLI📊 Changes
16 files changed (+250 additions, -69 deletions)
View changed files
📝
appinfo/info.xml(+1 -0)➕
lib/Command/Remove.php(+85 -0)📝
lib/Service/Gateway/SMS/GatewayConfig.php(+4 -0)📝
lib/Service/Gateway/SMS/Provider/ClickatellCentralConfig.php(+13 -6)📝
lib/Service/Gateway/SMS/Provider/ClockworkSMSConfig.php(+11 -4)📝
lib/Service/Gateway/SMS/Provider/EcallSMSConfig.php(+13 -6)📝
lib/Service/Gateway/SMS/Provider/HuaweiE3531Config.php(+11 -4)📝
lib/Service/Gateway/SMS/Provider/OvhConfig.php(+16 -9)📝
lib/Service/Gateway/SMS/Provider/PlaySMSConfig.php(+13 -6)📝
lib/Service/Gateway/SMS/Provider/PuzzelSMSConfig.php(+14 -7)📝
lib/Service/Gateway/SMS/Provider/Sms77IoConfig.php(+11 -4)📝
lib/Service/Gateway/SMS/Provider/SpryngSMSConfig.php(+11 -4)📝
lib/Service/Gateway/SMS/Provider/VoipMsConfig.php(+13 -6)📝
lib/Service/Gateway/SMS/Provider/WebSmsConfig.php(+12 -5)📝
lib/Service/Gateway/Signal/GatewayConfig.php(+11 -4)📝
lib/Service/Gateway/Telegram/GatewayConfig.php(+11 -4)📄 Description
This fixes #331 - adds a
twofactorauth:gateway:removecommand to the OCC CLI.@ChristophWurst I was wondering if it wouldn't make sense to move some functions of the gateway (-provider) in a parent class since they are very much the same everywhere.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.