[PR #307] [MERGED] explicitely convert elemet of the SimpleXML object #374

New issue

Closed

opened 2026-02-26 06:30:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:30:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/307
Author: @MaKess
Created: 12/21/2019
Status: ✅ Merged
Merged: 5/11/2020
Merged by: @ChristophWurst

Base: master ← Head: huawei_e3531_fix_xml

📝 Commits (1)

02e465f explicitely convert elemet of the SimpleXML object

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 lib/Service/Gateway/SMS/Provider/HuaweiE3531.php (+2 -2)

📄 Description

previously it was enough to use the elements of a SimpleXML object
directly when assembling the header for the following HTTP query as the
conversion to a string was happening implicitely:

  'headers' => [
    '__RequestVerificationToken' => $sessionTokenXml->TokInfo,
  ]

but something in the HTTP library has changed and now it was complaining
that not all elements of the header are strings.
Therefor the conversion is done explicitely:

  'headers' => [
    '__RequestVerificationToken' => (string) $sessionTokenXml->TokInfo,
  ]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/307 **Author:** [@MaKess](https://github.com/MaKess) **Created:** 12/21/2019 **Status:** ✅ Merged **Merged:** 5/11/2020 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `huawei_e3531_fix_xml` --- ### 📝 Commits (1) - [`02e465f`](https://github.com/nextcloud/twofactor_gateway/commit/02e465fc6911ff237409346c16a5afca892c7a89) explicitely convert elemet of the SimpleXML object ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lib/Service/Gateway/SMS/Provider/HuaweiE3531.php` (+2 -2) </details> ### 📄 Description previously it was enough to use the elements of a SimpleXML object directly when assembling the header for the following HTTP query as the conversion to a string was happening implicitely: ``` 'headers' => [ '__RequestVerificationToken' => $sessionTokenXml->TokInfo, ] ``` but something in the HTTP library has changed and now it was complaining that not all elements of the header are strings. Therefor the conversion is done explicitely: ``` 'headers' => [ '__RequestVerificationToken' => (string) $sessionTokenXml->TokInfo, ] ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 06:30:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#374

No description provided.

Rows
Columns