[PR #245] [CLOSED] WIP: Email as a 2nd factor. #326

New issue

Closed

opened 2026-02-26 05:34:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:34:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/245
Author: @Flow86
Created: 6/14/2019
Status: ❌ Closed

Base: master ← Head: email-verification

📝 Commits (1)

b3527d5 First implementation of Email as a 2nd factor.

📊 Changes

15 files changed (+471 additions, -7 deletions)

View changed files

📝 appinfo/info.xml (+1 -0)
📝 composer.json (+1 -1)
➕ js/components/EmailInstructions.vue (+13 -0)
➕ js/components/EmailSettings.vue (+145 -0)
📝 js/init.js (+5 -0)
➕ js/views/EmailSettings.vue (+38 -0)
📝 lib/Command/Configure.php (+14 -2)
📝 lib/Command/Status.php (+9 -1)
📝 lib/Command/Test.php (+10 -1)
📝 lib/Provider/AProvider.php (+1 -0)
➕ lib/Provider/EmailProvider.php (+70 -0)
📝 lib/Provider/Factory.php (+8 -1)
➕ lib/Service/Gateway/Email/Gateway.php (+90 -0)
➕ lib/Service/Gateway/Email/GatewayConfig.php (+57 -0)
📝 lib/Service/Gateway/Factory.php (+9 -1)

📄 Description

Hi,
since I didn't find a working email two factor solution, I've "hacked" it into this app.

Some caveats/TODOs:

I don't know how to pre set the users email address as identifier, so the user can specify a different one than the users email address.
Also the user has to manually enable email 2nd factor (could/should be automatically on if 2nd factor is forced?)
There are no unittests yet
The email interface IMailer is hardcoded
A email template should be used to allow translations

Perhaps someone helps this code to add a proper implementation?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/245 **Author:** [@Flow86](https://github.com/Flow86) **Created:** 6/14/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `email-verification` --- ### 📝 Commits (1) - [`b3527d5`](https://github.com/nextcloud/twofactor_gateway/commit/b3527d5d1ad17991334fc15889be854209171958) First implementation of Email as a 2nd factor. ### 📊 Changes **15 files changed** (+471 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `appinfo/info.xml` (+1 -0) 📝 `composer.json` (+1 -1) ➕ `js/components/EmailInstructions.vue` (+13 -0) ➕ `js/components/EmailSettings.vue` (+145 -0) 📝 `js/init.js` (+5 -0) ➕ `js/views/EmailSettings.vue` (+38 -0) 📝 `lib/Command/Configure.php` (+14 -2) 📝 `lib/Command/Status.php` (+9 -1) 📝 `lib/Command/Test.php` (+10 -1) 📝 `lib/Provider/AProvider.php` (+1 -0) ➕ `lib/Provider/EmailProvider.php` (+70 -0) 📝 `lib/Provider/Factory.php` (+8 -1) ➕ `lib/Service/Gateway/Email/Gateway.php` (+90 -0) ➕ `lib/Service/Gateway/Email/GatewayConfig.php` (+57 -0) 📝 `lib/Service/Gateway/Factory.php` (+9 -1) </details> ### 📄 Description Hi, since I didn't find a working email two factor solution, I've "hacked" it into this app. Some caveats/TODOs: - I don't know how to pre set the users email address as identifier, so the user can specify a different one than the users email address. - Also the user has to manually enable email 2nd factor (could/should be automatically on if 2nd factor is forced?) - There are no unittests yet - The email interface IMailer is hardcoded - A email template should be used to allow translations Perhaps someone helps this code to add a proper implementation? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:34:35 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 06:30:34 +03:00

[PR #326] [MERGED] Bump webpack-cli from 3.3.10 to 3.3.11 #392

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#326

No description provided.

Rows
Columns