[GH-ISSUE #97] Disabling second factor does not ask for confirmation #30

Open
opened 2026-02-26 05:32:30 +03:00 by kerem · 3 comments
Owner

Originally created by @morph027 on GitHub (Aug 26, 2018).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/97

Just tried the thing using Signal and it's awsome, just works straight away.

Just a hint, disabling the second factor should probably ask for one last confirmation code ;)

Originally created by @morph027 on GitHub (Aug 26, 2018). Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/97 Just tried the thing using Signal and it's awsome, just works straight away. Just a hint, disabling the second factor should probably ask for one last confirmation code ;)
Author
Owner

@ChristophWurst commented on GitHub (Aug 26, 2018):

Hey, I'm glad you like it, esp. since it's your Docker image that we use to send the codes! Are you at the conf? ✌

Yes, good point. We have to add confirmation. Other 2FA prividers have also password protection for enabling/disabling the provider. Would make sense to add this here, too.

<!-- gh-comment-id:416043428 --> @ChristophWurst commented on GitHub (Aug 26, 2018): Hey, I'm glad you like it, esp. since it's your Docker image that we use to send the codes! Are you at the conf? ✌ Yes, good point. We have to add confirmation. Other 2FA prividers have also password protection for enabling/disabling the provider. Would make sense to add this here, too.
Author
Owner

@morph027 commented on GitHub (Aug 26, 2018):

Yes, was at the conf but need to leave now for the bus. Would have loved to talk more about if only I had knew before.

Anyway, I'm pretty sure we can solve things here too ;)

<!-- gh-comment-id:416047993 --> @morph027 commented on GitHub (Aug 26, 2018): Yes, was at the conf but need to leave now for the bus. Would have loved to talk more about if only I had knew before. Anyway, I'm pretty sure we can solve things here too ;)
Author
Owner

@ChristophWurst commented on GitHub (Aug 27, 2018):

What a pity!

Yes, we can 🚀

<!-- gh-comment-id:416165795 --> @ChristophWurst commented on GitHub (Aug 27, 2018): What a pity! Yes, we can :rocket:
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/twofactor_gateway-nextcloud#30
No description provided.