mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 09:05:55 +03:00
[GH-ISSUE #97] Disabling second factor does not ask for confirmation #30
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#30
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @morph027 on GitHub (Aug 26, 2018).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/97
Just tried the thing using Signal and it's awsome, just works straight away.
Just a hint, disabling the second factor should probably ask for one last confirmation code ;)
@ChristophWurst commented on GitHub (Aug 26, 2018):
Hey, I'm glad you like it, esp. since it's your Docker image that we use to send the codes! Are you at the conf? ✌
Yes, good point. We have to add confirmation. Other 2FA prividers have also password protection for enabling/disabling the provider. Would make sense to add this here, too.
@morph027 commented on GitHub (Aug 26, 2018):
Yes, was at the conf but need to leave now for the bus. Would have loved to talk more about if only I had knew before.
Anyway, I'm pretty sure we can solve things here too ;)
@ChristophWurst commented on GitHub (Aug 27, 2018):
What a pity!
Yes, we can 🚀