[PR #114] [MERGED] Remove dead code and increase test coverage #215

New issue

Closed

opened 2026-02-26 05:34:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:34:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/114
Author: @ChristophWurst
Created: 9/19/2018
Status: ✅ Merged
Merged: 9/19/2018
Merged by: @ChristophWurst

Base: master ← Head: fix/remove-dead-code-increase-coverage

📝 Commits (2)

ef0c80b Remove dead TestGateway class
dea113c Add unit tests for the gateway state and factory classes

📊 Changes

4 files changed (+144 additions, -52 deletions)

View changed files

📝 lib/Service/Gateway/State.php (+2 -2)
➖ lib/Service/Gateway/TestGateway.php (+0 -50)
➕ tests/Unit/Service/Gateway/FactoryTest.php (+86 -0)
➕ tests/Unit/Service/Gateway/StateTest.php (+56 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/114 **Author:** [@ChristophWurst](https://github.com/ChristophWurst) **Created:** 9/19/2018 **Status:** ✅ Merged **Merged:** 9/19/2018 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `fix/remove-dead-code-increase-coverage` --- ### 📝 Commits (2) - [`ef0c80b`](https://github.com/nextcloud/twofactor_gateway/commit/ef0c80b84891ac82f53ea0176eacacd58c8eecde) Remove dead TestGateway class - [`dea113c`](https://github.com/nextcloud/twofactor_gateway/commit/dea113c997594b4d1afb4857810c3f4c39a9979f) Add unit tests for the gateway state and factory classes ### 📊 Changes **4 files changed** (+144 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `lib/Service/Gateway/State.php` (+2 -2) ➖ `lib/Service/Gateway/TestGateway.php` (+0 -50) ➕ `tests/Unit/Service/Gateway/FactoryTest.php` (+86 -0) ➕ `tests/Unit/Service/Gateway/StateTest.php` (+56 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:34:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#215

No description provided.

Rows
Columns