[PR #59] [MERGED] Let providers specify their name to cause less confusion #175

New issue

Closed

opened 2026-02-26 05:33:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:33:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/59
Author: @ChristophWurst
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/25/2018
Merged by: @ChristophWurst

Base: master ← Head: enhancement/provider-name-description

📝 Commits (2)

d5dbee3 Rename gateway interface
2bd74e9 Let gateways tell their name to make it more clear how users receive codes

📊 Changes

13 files changed (+99 additions, -34 deletions)

View changed files

📝 js/view/settings.vue (+12 -5)
📝 lib/AppInfo/Application.php (+2 -2)
📝 lib/Provider/SmsProvider.php (+3 -3)
📝 lib/Provider/State.php (+6 -1)
📝 lib/Service/Gateway/PlaySMSGateway.php (+11 -2)
📝 lib/Service/Gateway/SignalGateway.php (+11 -2)
📝 lib/Service/Gateway/TelegramGateway.php (+12 -3)
📝 lib/Service/Gateway/TestGateway.php (+11 -2)
📝 lib/Service/Gateway/WebSmsGateway.php (+12 -3)
📝 lib/Service/IGateway.php (+10 -2)
📝 lib/Service/SetupService.php (+3 -3)
📝 tests/Unit/Provider/SmsProviderTest.php (+3 -3)
📝 tests/Unit/Service/SetupServiceTest.php (+3 -3)

📄 Description

Otherwise SMS was wrong in many cases (e.g. when using Telegram as gateway).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/59 **Author:** [@ChristophWurst](https://github.com/ChristophWurst) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/25/2018 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `enhancement/provider-name-description` --- ### 📝 Commits (2) - [`d5dbee3`](https://github.com/nextcloud/twofactor_gateway/commit/d5dbee3e1e2d4506f4945b46865aa499adddfdf8) Rename gateway interface - [`2bd74e9`](https://github.com/nextcloud/twofactor_gateway/commit/2bd74e9fea26731a722a594979279f0c6de799ac) Let gateways tell their name to make it more clear how users receive codes ### 📊 Changes **13 files changed** (+99 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `js/view/settings.vue` (+12 -5) 📝 `lib/AppInfo/Application.php` (+2 -2) 📝 `lib/Provider/SmsProvider.php` (+3 -3) 📝 `lib/Provider/State.php` (+6 -1) 📝 `lib/Service/Gateway/PlaySMSGateway.php` (+11 -2) 📝 `lib/Service/Gateway/SignalGateway.php` (+11 -2) 📝 `lib/Service/Gateway/TelegramGateway.php` (+12 -3) 📝 `lib/Service/Gateway/TestGateway.php` (+11 -2) 📝 `lib/Service/Gateway/WebSmsGateway.php` (+12 -3) 📝 `lib/Service/IGateway.php` (+10 -2) 📝 `lib/Service/SetupService.php` (+3 -3) 📝 `tests/Unit/Provider/SmsProviderTest.php` (+3 -3) 📝 `tests/Unit/Service/SetupServiceTest.php` (+3 -3) </details> ### 📄 Description Otherwise `SMS` was wrong in many cases (e.g. when using Telegram as gateway). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:33:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 05:34:15 +03:00

[PR #175] [CLOSED] Bump vue-loader from 15.4.2 to 15.5.0 #266

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#175

No description provided.

Rows
Columns