[PR #44] [MERGED] Use session-bound password instead of OTP #166

New issue

Closed

opened 2026-02-26 05:33:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:33:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/44
Author: @ChristophWurst
Created: 4/10/2018
Status: ✅ Merged
Merged: 4/11/2018
Merged by: @ChristophWurst

Base: master ← Head: enhancement/session-bound-password

📝 Commits (3)

116eb53 Use session-bound password instead of OTP
d098e0d Fix unit test
904fc12 Ignore clover coverage file

📊 Changes

6 files changed (+47 additions, -129 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 composer.json (+0 -1)
📝 composer.lock (+5 -110)
📝 lib/Provider/SmsProvider.php (+31 -15)
📝 lib/Service/SmsProvider/SignalGateway.php (+3 -2)
📝 tests/Unit/Provider/SmsProviderTest.php (+6 -1)

📄 Description

It's the very same OTP class used in the TOTP app, so this caused conflicts.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/44 **Author:** [@ChristophWurst](https://github.com/ChristophWurst) **Created:** 4/10/2018 **Status:** ✅ Merged **Merged:** 4/11/2018 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `enhancement/session-bound-password` --- ### 📝 Commits (3) - [`116eb53`](https://github.com/nextcloud/twofactor_gateway/commit/116eb533538de29679f0a873b010132ee984264e) Use session-bound password instead of OTP - [`d098e0d`](https://github.com/nextcloud/twofactor_gateway/commit/d098e0da41e106b14cfd051e16611568ccfd5c28) Fix unit test - [`904fc12`](https://github.com/nextcloud/twofactor_gateway/commit/904fc121e5505573f47a2621e568be35395d270d) Ignore clover coverage file ### 📊 Changes **6 files changed** (+47 additions, -129 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `composer.json` (+0 -1) 📝 `composer.lock` (+5 -110) 📝 `lib/Provider/SmsProvider.php` (+31 -15) 📝 `lib/Service/SmsProvider/SignalGateway.php` (+3 -2) 📝 `tests/Unit/Provider/SmsProviderTest.php` (+6 -1) </details> ### 📄 Description It's the very same OTP class used in the TOTP app, so this caused conflicts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:33:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 05:34:13 +03:00

[PR #166] [CLOSED] Bump css-loader from 1.0.1 to 2.0.2 #260

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#166

No description provided.

Rows
Columns