starred/twofactor_gateway-nextcloud

Fork 0

mirror of https://github.com/nextcloud/twofactor_gateway.git synced 2026-04-26 09:35:50 +03:00

[GH-ISSUE #31] Use Nextcloud-stored phone? #11

New issue

Closed

opened 2026-02-26 05:32:22 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 05:32:22 +03:00

Owner

Originally created by @mario on GitHub (Feb 12, 2018).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/31

github.com/nextcloud/twofactor_sms@46d047082f/lib/Provider/SmsProvider.php (L102)

Could we instead of doing this use phone that user enters in their Profile? Would make it so much easier.

Originally created by @mario on GitHub (Feb 12, 2018). Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/31 https://github.com/nextcloud/twofactor_sms/blob/46d047082fd7f09c0307fc13a64756e539b1c419/lib/Provider/SmsProvider.php#L102 Could we instead of doing this use phone that user enters in their Profile? Would make it so much easier.

kerem

2026-02-26 05:32:22 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-26 05:32:22 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Feb 12, 2018):

It totally would, yes.

@ChristophWurst commented on GitHub (Feb 12, 2018): It totally would, yes.

kerem commented

2026-02-26 05:32:22 +03:00

Author

Owner

@mario commented on GitHub (Feb 12, 2018):

Let's do that :D Do we need to force the field in Nextcloud to use proper format first though?

@mario commented on GitHub (Feb 12, 2018): Let's do that :D Do we need to force the field in Nextcloud to use proper format first though?

kerem commented

2026-02-26 05:32:23 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Feb 12, 2018):

Yes, that's the pain point. You don't reliably know whether a phone number is set and the UI also does not mention the number being used for 2FA.

@ChristophWurst commented on GitHub (Feb 12, 2018): Yes, that's the pain point. You don't reliably know whether a phone number is set and the UI also does not mention the number being used for 2FA.

kerem commented

2026-02-26 05:32:23 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Feb 12, 2018):

Oh, I think I misread your comment. But yes, we do have to make sure the format suits the messaging back-end. And we have to communicate that the number is used for 2FA as well.

@ChristophWurst commented on GitHub (Feb 12, 2018): Oh, I think I misread your comment. But yes, we do have to make sure the format suits the messaging back-end. And we have to communicate that the number is used for 2FA as well.

kerem commented

2026-02-26 05:32:23 +03:00

Author

Owner

@ChristophWurst commented on GitHub (Apr 30, 2018):

Oh, I think I misread your comment. But yes, we do have to make sure the format suits the messaging back-end. And we have to communicate that the number is used for 2FA as well.

-> https://github.com/ChristophWurst/twofactor_sms/pull/45

@ChristophWurst commented on GitHub (Apr 30, 2018): > Oh, I think I misread your comment. But yes, we do have to make sure the format suits the messaging back-end. And we have to communicate that the number is used for 2FA as well. -> https://github.com/ChristophWurst/twofactor_sms/pull/45

kerem referenced this issue

2026-02-26 05:33:42 +03:00

[PR #11] [MERGED] Update to 11 #142

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#11

No description provided.

Rows
Columns