[PR #610] [CLOSED] Add support for styling the borders used with modals. #994

New issue

Closed

opened 2026-03-04 01:08:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/610
Author: @gdamore
Created: 5/28/2021
Status: ❌ Closed

Base: master ← Head: modal-borders

📝 Commits (1)

4f66010 Add support for styling the borders used with modals.

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 modal.go (+12 -0)

📄 Description

It turns out that I need to have more control over the styling of these borders. This small addition fixes that. (Note that due to inheritance from Box we had this method already, but it basically didn't do what you expected -- we need to control the frame's borders, not the box's.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/610 **Author:** [@gdamore](https://github.com/gdamore) **Created:** 5/28/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `modal-borders` --- ### 📝 Commits (1) - [`4f66010`](https://github.com/rivo/tview/commit/4f66010c494174e03a7558c5ee54b01f4434accd) Add support for styling the borders used with modals. ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modal.go` (+12 -0) </details> ### 📄 Description It turns out that I need to have more control over the styling of these borders. This small addition fixes that. (Note that due to inheritance from Box we had this method already, but it basically didn't do what you expected -- we need to control the frame's borders, not the box's. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>