[PR #524] [CLOSED] Match box border bg with box bg color #976

New issue

Closed

opened 2026-03-04 01:08:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/524
Author: @polothy
Created: 11/6/2020
Status: ❌ Closed

Base: master ← Head: box-border-bg-color

📝 Commits (1)

efa1179 Match box border bg with box bg color

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 box.go (+2 -1)

📄 Description

fixes https://github.com/rivo/tview/issues/519

Before change:

After change:

Notice the background color of the border around each frame box and the modal.

One mystery: if I checkout github.com/rivo/tview@53d50e499b and run the presentation demo, the modal color is a dark blue. Unsure why it changes color, maybe something with tcell upgrade?

Unsure if this is the best way to fix this problem, so open to suggestions. I guess an alternative would be to revert the switch to using the borderStyle property? Cheers!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/524 **Author:** [@polothy](https://github.com/polothy) **Created:** 11/6/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `box-border-bg-color` --- ### 📝 Commits (1) - [`efa1179`](https://github.com/rivo/tview/commit/efa1179c0f5471644a97a56250203800bb32fe18) Match box border bg with box bg color ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `box.go` (+2 -1) </details> ### 📄 Description fixes https://github.com/rivo/tview/issues/519 Before change: ![presentation_demo](https://user-images.githubusercontent.com/634657/98324529-5f0fd180-1fa1-11eb-8c61-7f1b8cdc4fb5.png) After change: ![Screen Shot 2020-11-05 at 7 54 42 PM](https://user-images.githubusercontent.com/634657/98324543-6636df80-1fa1-11eb-9920-c359afd4ed59.png) Notice the background color of the border around each frame box and the modal. One mystery: if I checkout https://github.com/rivo/tview/commit/53d50e499bf914fbd2873aa7d8b1bcb6427dde0e and run the presentation demo, the modal color is a dark blue. Unsure why it changes color, maybe something with tcell upgrade? Unsure if this is the best way to fix this problem, so open to suggestions. I guess an alternative would be to revert the switch to using the `borderStyle` property? Cheers! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>