[PR #523] [CLOSED] Apply background colour when drawing Box border #975

New issue

Closed

opened 2026-03-04 01:08:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/523
Author: @berrange
Created: 11/5/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

da9053a Apply background colour when drawing Box border

📊 Changes

1 file changed (+10 additions, -8 deletions)

View changed files

📝 box.go (+10 -8)

📄 Description

The borderStyle field only encodes the foreground colour of the border,
leaving the background to inherit from the terminal default theme. This
often means the border is draw white-on-white, which is a regression
introduced by the tcell v2 update.

It needs to honour the background colour set for the Box instance
when drawing the border.

Fixes: https://github.com/rivo/tview/issues/521

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/523 **Author:** [@berrange](https://github.com/berrange) **Created:** 11/5/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`da9053a`](https://github.com/rivo/tview/commit/da9053a5590a0e7346515ab8daaa710f5184e2a4) Apply background colour when drawing Box border ### 📊 Changes **1 file changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `box.go` (+10 -8) </details> ### 📄 Description The borderStyle field only encodes the foreground colour of the border, leaving the background to inherit from the terminal default theme. This often means the border is draw white-on-white, which is a regression introduced by the tcell v2 update. It needs to honour the background colour set for the Box instance when drawing the border. Fixes: https://github.com/rivo/tview/issues/521 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>