[PR #503] Lock until replacement is initialized #969

Open
opened 2026-03-04 01:08:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/503
Author: @rlmaers
Created: 9/25/2020
Status: 🔄 Open

Base: masterHead: rlmaers


📝 Commits (1)

  • 573db3c Lock until replacement is initialized

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 application.go (+1 -1)

📄 Description

I've experienced seemingly random hangs after returning from a suspend. After a lot of debugging, it seems that the issue is due to a call to Application.draw from the event loop before the replacement screen has been fully initialized. This aims to fix that race condition, and it's also how it's done in Application.Run (i.e. lock until screen has been fully initialized).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/503 **Author:** [@rlmaers](https://github.com/rlmaers) **Created:** 9/25/2020 **Status:** 🔄 Open **Base:** `master` ← **Head:** `rlmaers` --- ### 📝 Commits (1) - [`573db3c`](https://github.com/rivo/tview/commit/573db3ced4c604f1f5971b39b1c95e0157b36e80) Lock until replacement is initialized ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `application.go` (+1 -1) </details> ### 📄 Description I've experienced seemingly random hangs after returning from a suspend. After a lot of debugging, it seems that the issue is due to a call to Application.draw from the event loop before the replacement screen has been fully initialized. This aims to fix that race condition, and it's also how it's done in Application.Run (i.e. lock until screen has been fully initialized). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tview#969
No description provided.