[PR #444] [MERGED] Fixed terminal colors #956

New issue

Closed

opened 2026-03-04 01:08:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/444
Author: @mjwhitta
Created: 5/11/2020
Status: ✅ Merged
Merged: 5/28/2020
Merged by: @rivo

Base: master ← Head: master

📝 Commits (3)

1bab239 Fixed terminal colors
971141a Fixed 8-bit background colors
9fa0388 Ran go fmt for consistency

📊 Changes

1 file changed (+20 additions, -25 deletions)

View changed files

📝 ansi.go (+20 -25)

📄 Description

I was noticing some very weird issues related to color. I tracked it down to this color slice. I grabbed the color names from tcell, so hopefully colors 000-015 are acceptable now.

It wasn't completely noticeable with the Tango colorscheme:

But was much more noticeable with the Solarized Dark colorscheme:

This should fix #445.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/444 **Author:** [@mjwhitta](https://github.com/mjwhitta) **Created:** 5/11/2020 **Status:** ✅ Merged **Merged:** 5/28/2020 **Merged by:** [@rivo](https://github.com/rivo) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`1bab239`](https://github.com/rivo/tview/commit/1bab2394e40947f8a114223adceec179bc663207) Fixed terminal colors - [`971141a`](https://github.com/rivo/tview/commit/971141a5d91f755b0a12b851c844e346fec8eee5) Fixed 8-bit background colors - [`9fa0388`](https://github.com/rivo/tview/commit/9fa0388a745ed8a2ed69cd67a73bb9c8bde57fb1) Ran go fmt for consistency ### 📊 Changes **1 file changed** (+20 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `ansi.go` (+20 -25) </details> ### 📄 Description I was noticing some very weird issues related to color. I tracked it down to this color slice. I grabbed the color names from tcell, so hopefully colors 000-015 are acceptable now. It wasn't completely noticeable with the Tango colorscheme: ![tango_before_and_after](https://user-images.githubusercontent.com/1239825/81633892-bf9bc880-93db-11ea-925f-a718c503dde7.png) But was much more noticeable with the Solarized Dark colorscheme: ![solarizeddark_before_and_after](https://user-images.githubusercontent.com/1239825/81633933-d80be300-93db-11ea-946d-19b296f0cdbc.png) This should fix #445. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>