[PR #344] [CLOSED] Refactor: make the correct processing of SGR code #919

New issue

Closed

opened 2026-03-04 01:08:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/344
Author: @dzpao
Created: 9/12/2019
Status: ❌ Closed

Base: master ← Head: fix/issue-320

📝 Commits (1)

7e3eb05 Refactor: make the correct processing of SGR code

📊 Changes

3 files changed (+205 additions, -58 deletions)

View changed files

📝 ansi.go (+157 -41)
📝 textview.go (+8 -3)
📝 util.go (+40 -14)

📄 Description

SGR code 21/22/23/24/25/27 should not turn off all attributes.
turn on/off one of bold/dim/underline/blink should not turn off other attributes.

This should fix #320

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/344 **Author:** [@dzpao](https://github.com/dzpao) **Created:** 9/12/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/issue-320` --- ### 📝 Commits (1) - [`7e3eb05`](https://github.com/rivo/tview/commit/7e3eb050fe6bb2140b852c51f0d7aba83e08c782) Refactor: make the correct processing of SGR code ### 📊 Changes **3 files changed** (+205 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `ansi.go` (+157 -41) 📝 `textview.go` (+8 -3) 📝 `util.go` (+40 -14) </details> ### 📄 Description * SGR code 21/22/23/24/25/27 should not turn off all attributes. * turn on/off one of bold/dim/underline/blink should not turn off other attributes. This should fix #320 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>