[PR #275] [CLOSED] Added traceEnd=false when scrolling #894

Closed
opened 2026-03-04 01:08:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/275
Author: @thorsager
Created: 4/22/2019
Status: Closed

Base: masterHead: scroll-fix


📝 Commits (1)

  • 4675443 Added traceEnd=false when scrolling

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 textview.go (+1 -0)

📄 Description

I have not done a lot of research, so this might NOT be the right way of fixing the .ScrollTo(row,column) not-working-issue.

I found that the TextView sets trackEnd=false when scrolling up on PgUP but if you want to scroll based on external event it is not working.

Anyway.. This patch fixed my issue, :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/275 **Author:** [@thorsager](https://github.com/thorsager) **Created:** 4/22/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `scroll-fix` --- ### 📝 Commits (1) - [`4675443`](https://github.com/rivo/tview/commit/467544351b5ffcfbd03fb00e92369a035881fe10) Added traceEnd=false when scrolling ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `textview.go` (+1 -0) </details> ### 📄 Description I have *not* done a lot of research, so this might NOT be the right way of fixing the `.ScrollTo(row,column)` not-working-issue. I found that the `TextView` sets `trackEnd=false` when scrolling up on `PgUP` but if you want to scroll based on _external_ event it is not working. Anyway.. This patch fixed my issue, :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 01:08:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tview#894
No description provided.