[PR #271] [CLOSED] Fix list ColorDefault issue #270 #893

New issue

Closed

opened 2026-03-04 01:08:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/271
Author: @eu81273
Created: 4/19/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

ed19232 Fix list ColorDefault issue
6fd928c Fix box to draw ColorDefault backgroundColor

📊 Changes

2 files changed (+20 additions, -6 deletions)

View changed files

📝 box.go (+3 -5)
📝 list.go (+17 -1)

📄 Description

This PR is for #270

Bug Fix

As described in #270, list have two problem with tcell.ColorDefault(-1) background.

When the list is updated, the updated list and the previous list are overlapped.
When move the cursor down, the previous item remains in the selected background color.

To fix this issue, I added background fields for drawing unselected item's background. (Is there any way to get Box's background value?)
And I modified main text printing logic to print with blank spaces for erase previous main text.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/271 **Author:** [@eu81273](https://github.com/eu81273) **Created:** 4/19/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ed19232`](https://github.com/rivo/tview/commit/ed19232af57831285df6444844f7df4057f5a724) Fix list ColorDefault issue - [`6fd928c`](https://github.com/rivo/tview/commit/6fd928c95d49b65a2e4fbab3a9f15d3cd1761da1) Fix box to draw ColorDefault backgroundColor ### 📊 Changes **2 files changed** (+20 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `box.go` (+3 -5) 📝 `list.go` (+17 -1) </details> ### 📄 Description This PR is for #270 **Bug Fix** As described in #270, list have two problem with tcell.ColorDefault(-1) background. - When the list is updated, the updated list and the previous list are overlapped. - When move the cursor down, the previous item remains in the selected background color. To fix this issue, I added background fields for drawing unselected item's background. (Is there any way to get Box's background value?) And I modified main text printing logic to print with blank spaces for erase previous main text. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>