[PR #235] [MERGED] Prevent recompilation of regexes #886

New issue

Closed

opened 2026-03-04 01:08:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/235
Author: @Bios-Marcel
Created: 2/13/2019
Status: ✅ Merged
Merged: 2/13/2019
Merged by: @rivo

Base: master ← Head: prevent-regex-recompilation

📝 Commits (2)

f4690e4 Prevent recompilation of regexes
f3b5afb Move TabSize comment in texview.go back to where it belongs.

📊 Changes

1 file changed (+11 additions, -8 deletions)

View changed files

📝 textview.go (+11 -8)

📄 Description

I have noticed that there are some regular expressions in textview.go that get recompiled every time that they are needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/235 **Author:** [@Bios-Marcel](https://github.com/Bios-Marcel) **Created:** 2/13/2019 **Status:** ✅ Merged **Merged:** 2/13/2019 **Merged by:** [@rivo](https://github.com/rivo) **Base:** `master` ← **Head:** `prevent-regex-recompilation` --- ### 📝 Commits (2) - [`f4690e4`](https://github.com/rivo/tview/commit/f4690e43a0cefd27f35157f4f9181a1a19b4d0e3) Prevent recompilation of regexes - [`f3b5afb`](https://github.com/rivo/tview/commit/f3b5afb8cd13200197c508a906c8b51e5d6c5747) Move TabSize comment in texview.go back to where it belongs. ### 📊 Changes **1 file changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `textview.go` (+11 -8) </details> ### 📄 Description I have noticed that there are some regular expressions in textview.go that get recompiled every time that they are needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>