[PR #135] [MERGED] Block main event loop with mutex during Suspend() call #861

New issue

Closed

opened 2026-03-04 01:08:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/135
Author: @kvj
Created: 6/20/2018
Status: ✅ Merged
Merged: 6/28/2018
Merged by: @rivo

Base: master ← Head: suspend-in-goroutine

📝 Commits (2)

2ac0e9e Block main event loop with mutex during Suspend() call
01a39a4 Review feedback

📊 Changes

1 file changed (+10 additions, -17 deletions)

View changed files

📝 application.go (+10 -17)

📄 Description

Fixes #134

Please take a look on it.
This replaces suspended bool flag with dedicated mutex, which simplifies code and fixes above mentioned bug

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/135 **Author:** [@kvj](https://github.com/kvj) **Created:** 6/20/2018 **Status:** ✅ Merged **Merged:** 6/28/2018 **Merged by:** [@rivo](https://github.com/rivo) **Base:** `master` ← **Head:** `suspend-in-goroutine` --- ### 📝 Commits (2) - [`2ac0e9e`](https://github.com/rivo/tview/commit/2ac0e9e086dad67014b6b0b5b2a695b138a02842) Block main event loop with mutex during Suspend() call - [`01a39a4`](https://github.com/rivo/tview/commit/01a39a486dcc438baa4fb091ab301a20898a02b1) Review feedback ### 📊 Changes **1 file changed** (+10 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `application.go` (+10 -17) </details> ### 📄 Description Fixes #134 Please take a look on it. This replaces `suspended bool` flag with dedicated mutex, which simplifies code and fixes above mentioned bug --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>