[PR #126] [MERGED] Refactored semigraphics and configurable borders #860

New issue

Closed

opened 2026-03-04 01:08:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/126
Author: @benweidig
Created: 5/26/2018
Status: ✅ Merged
Merged: 6/15/2018
Merged by: @rivo

Base: master ← Head: fix_borders

📝 Commits (7)

76fdcb4 fix borders and add unicode comment
2e0f146 refactored semigraphics
29553e5 added configurable borders
06dd160 replaced old borders code with new configurable borders
b6cd5e5 added comment to semigraphic related code
e8c92a7 Added visualization to SemigraphicJoints
7ad390e Removed deprecated funcs/const related to semigraphic changes

📊 Changes

7 files changed (+383 additions, -152 deletions)

View changed files

➕ borders.go (+45 -0)
📝 box.go (+17 -17)
📝 demos/presentation/table.go (+2 -2)
📝 grid.go (+8 -8)
➕ semigraphics.go (+296 -0)
📝 table.go (+15 -15)
📝 util.go (+0 -110)

📄 Description

Fixing horizontal/vertical in box.go, added comments to border runes for better visualization

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/126 **Author:** [@benweidig](https://github.com/benweidig) **Created:** 5/26/2018 **Status:** ✅ Merged **Merged:** 6/15/2018 **Merged by:** [@rivo](https://github.com/rivo) **Base:** `master` ← **Head:** `fix_borders` --- ### 📝 Commits (7) - [`76fdcb4`](https://github.com/rivo/tview/commit/76fdcb42e904128f735432b5db5462f2738dfeee) fix borders and add unicode comment - [`2e0f146`](https://github.com/rivo/tview/commit/2e0f1462446262e24f4b7ad2c544ca3a22ddb316) refactored semigraphics - [`29553e5`](https://github.com/rivo/tview/commit/29553e579468ab7602330e2e47e8c22fe6dbcd68) added configurable borders - [`06dd160`](https://github.com/rivo/tview/commit/06dd16088adb93ae07ecf3f523ead4794e6cd6ef) replaced old borders code with new configurable borders - [`b6cd5e5`](https://github.com/rivo/tview/commit/b6cd5e5021599d34cf2461a457333e64a040ad81) added comment to semigraphic related code - [`e8c92a7`](https://github.com/rivo/tview/commit/e8c92a715c6036f3c142b6149af281b850e3d06a) Added visualization to SemigraphicJoints - [`7ad390e`](https://github.com/rivo/tview/commit/7ad390eb5ead1c9842cb3d8567b7e84e277753ac) Removed deprecated funcs/const related to semigraphic changes ### 📊 Changes **7 files changed** (+383 additions, -152 deletions) <details> <summary>View changed files</summary> ➕ `borders.go` (+45 -0) 📝 `box.go` (+17 -17) 📝 `demos/presentation/table.go` (+2 -2) 📝 `grid.go` (+8 -8) ➕ `semigraphics.go` (+296 -0) 📝 `table.go` (+15 -15) 📝 `util.go` (+0 -110) </details> ### 📄 Description Fixing horizontal/vertical in box.go, added comments to border runes for better visualization --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>