[GH-ISSUE #934] More precise view customization of selected table cells #683

New issue

Closed

opened 2026-03-04 01:07:01 +03:00 by kerem · 4 comments

kerem commented

2026-03-04 01:07:01 +03:00

Owner

Originally created by @vlanse on GitHub (Jan 7, 2024).
Original GitHub issue: https://github.com/rivo/tview/issues/934

Currently selected style could by only set "globally" for table, so it overrides cell style completely when it is selected. There are cases when this such behavior is not ok, e.g. when content of table cells is displayed with different colors of cells depending on some params. When such a row with different cell colors is selected now, color differentiation is removed completely

I know that when selection style is not set, colors are "reverted", but this approach gives visually unpleasant results, at least in some cases.

Suggestion is to allow per-cell customization of appearance of selected cells, so selected style could be (optionally) set on a per-cell basis.

Originally created by @vlanse on GitHub (Jan 7, 2024). Original GitHub issue: https://github.com/rivo/tview/issues/934 Currently selected style could by only set "globally" for table, so it overrides cell style completely when it is selected. There are cases when this such behavior is not ok, e.g. when content of table cells is displayed with different colors of cells depending on some params. When such a row with different cell colors is selected now, color differentiation is removed completely I know that when selection style is not set, colors are "reverted", but this approach gives visually unpleasant results, at least in some cases. Suggestion is to allow per-cell customization of appearance of selected cells, so selected style could be (optionally) set on a per-cell basis.

kerem closed this issue

2026-03-04 01:07:01 +03:00

kerem commented

2026-03-04 01:07:01 +03:00

Author

Owner

@rivo commented on GitHub (Apr 4, 2024):

Can you provide an example where reverting the colours gives unpleasant results?

@rivo commented on GitHub (Apr 4, 2024): Can you provide an example where reverting the colours gives unpleasant results?

kerem commented

2026-03-04 01:07:02 +03:00

Author

Owner

@vlanse commented on GitHub (Apr 4, 2024):

Sure, here it is. IMO the selected line (45) is not even readable:

What I want is just to add the underline style to the selected row, but right now it could not be achieved, as you can see below, the color differentiation between the cells is lost (same line 45 selected below):

Best solution IMO would be to add underline style to selected row w/o changing the other styles.

@vlanse commented on GitHub (Apr 4, 2024): Sure, here it is. IMO the selected line (`45`) is not even readable: <img width="825" alt="Screenshot 2024-04-04 at 21 22 37" src="https://github.com/rivo/tview/assets/17192647/454cb0c9-fd1e-496a-97fd-dc2bd38a3eef"> What I want is just to add the underline style to the selected row, but right now it could not be achieved, as you can see below, the color differentiation between the cells is lost (same line `45` selected below): <img width="818" alt="Screenshot 2024-04-04 at 21 17 31" src="https://github.com/rivo/tview/assets/17192647/ce2a2cce-cf9a-4fbf-a525-c208b5159105"> Best solution IMO would be to add underline style to selected row w/o changing the other styles.

kerem commented

2026-03-04 01:07:02 +03:00

Author

Owner

@rivo commented on GitHub (Apr 6, 2024):

It seems to me that you're setting the cell's background colour to tcell.ColorDefault. And your default terminal color is some kind of grey. So swapping the colours leads to the background colour to be red (or green) and the foreground colour to be grey. Yes, that leads to low contrast.

I would suggest not to use tcell.ColorDefault here (or anywhere, for that matter). In your example, set it to tcell.ColorBlack. That's the default already so you don't really have to set anything here anyway.

@rivo commented on GitHub (Apr 6, 2024): It seems to me that you're setting the cell's background colour to `tcell.ColorDefault`. And your default terminal color is some kind of grey. So swapping the colours leads to the background colour to be red (or green) and the foreground colour to be grey. Yes, that leads to low contrast. I would suggest not to use `tcell.ColorDefault` here (or anywhere, for that matter). In your example, set it to `tcell.ColorBlack`. That's the default already so you don't really have to set anything here anyway.

kerem commented

2026-03-04 01:07:02 +03:00

Author

Owner

@rivo commented on GitHub (Apr 6, 2024):

But in any case, the latest commit introduces individual styling for selected cells.

@rivo commented on GitHub (Apr 6, 2024): But in any case, the latest commit introduces individual styling for selected cells.