mirror of
https://github.com/rivo/tview.git
synced 2026-04-26 21:35:54 +03:00
[GH-ISSUE #656] table scrolling wraps now? #483
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tview#483
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @toffaletti on GitHub (Sep 26, 2021).
Original GitHub issue: https://github.com/rivo/tview/issues/656
I updated to latest commit, implemented TableContent interface, and now I see this new behavior:
@rivo commented on GitHub (Sep 26, 2021):
Yes, that's true. Before this merge, it only wrapped in one direction which was quite inconsistent. I.e. you could move right and end up on the next line but if you moved left, you wouldn't be sent back. So that was unexpected and, in my opinion, undesirable.
If this is a problem in your application, please elaborate a bit why.
@rivo commented on GitHub (Sep 26, 2021):
Yes, that's true. Before this merge, it only wrapped in one direction which was quite inconsistent. I.e. you could move right and end up on the next line but if you moved left, you wouldn't be sent back. So that was unexpected and, in my opinion, undesirable.
If this is a problem in your application, please elaborate a bit why.
@rivo commented on GitHub (Sep 26, 2021):
Yes, that's true. Before this merge, it only wrapped in one direction which was quite inconsistent. I.e. you could move right and end up on the next line but if you moved left, you wouldn't be sent back. So that was unexpected and, in my opinion, undesirable.
If this is a problem in your application, please elaborate a bit why.
@toffaletti commented on GitHub (Sep 26, 2021):
It would be nice to have control over the behavior. In my case, holding page up to get back to the top of the table and have it stop was a desirable behavior because there are many pages and you might be in the middle somewhere and want to quickly get to the top. Now it just keeps wrapping to the bottom though.
@rivo commented on GitHub (Sep 26, 2021):
Makes sense. (Although pressing g / G will move the selection to the beginning / end.)
The latest commit introduces a way to control wrapping behaviour. After some consideration, I decided that the default should be that there is no wrapping. (I was never quite happy with the previous implementations.)