starred/tview

Fork 0

mirror of https://github.com/rivo/tview.git synced 2026-04-27 05:45:49 +03:00

go-runewidth to v0.0.10 #400

New issue

Closed

opened 2026-03-04 01:04:39 +03:00 by kerem · 6 comments

kerem commented

2026-03-04 01:04:39 +03:00

Owner

Originally created by @zemzale on GitHub (Jan 12, 2021).
Original GitHub issue: https://github.com/rivo/tview/issues/548

In glab we use both tview and go-runewidth

We can't update go-runewidth since this package requires v0.0.9. And there is a breaking change from v0.0.9 to v0.0.10 that removes runewidth.ZeroWidthJoiner which is used in https://github.com/rivo/tview/blob/master/util.go#L56

I locally did an update and nothing seemed to break, so I am ready to open an PR for this, if you are fine with this.

Originally created by @zemzale on GitHub (Jan 12, 2021). Original GitHub issue: https://github.com/rivo/tview/issues/548 In [glab](https://github.com/profclems/glab/pull/561) we use both `tview` and `go-runewidth` We can't update `go-runewidth` since this package requires v0.0.9. And there is a breaking change from v0.0.9 to v0.0.10 that removes `runewidth.ZeroWidthJoiner` which is used in `https://github.com/rivo/tview/blob/master/util.go#L56` I locally did an update and nothing seemed to break, so I am ready to open an PR for this, if you are fine with this.

kerem closed this issue

2026-03-04 01:04:39 +03:00

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@rivo commented on GitHub (Jan 12, 2021):

go-runewidth is imported indirectly by tcell and I opened an issue there (gdamore/tcell#423) to upgrade to the latest version so tview also gets the new version.

All of this happened yesterday (i.e. the change in go-runewidth) so I'm assuming (slash hoping) that it will be resolved these days. It shouldn't be a big effort.

@rivo commented on GitHub (Jan 12, 2021): `go-runewidth` is imported indirectly by [`tcell`](https://github.com/gdamore/tcell) and I opened an issue there (gdamore/tcell#423) to upgrade to the latest version so `tview` also gets the new version. All of this happened yesterday (i.e. the change in `go-runewidth`) so I'm assuming (slash hoping) that it will be resolved these days. It shouldn't be a big effort.

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@zemzale commented on GitHub (Jan 12, 2021):

Okay that's nice. Will wait for that then

@zemzale commented on GitHub (Jan 12, 2021): Okay that's nice. Will wait for that then

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@vainkop commented on GitHub (Jan 14, 2021):

go get github.com/orisano/dlayer
# github.com/rivo/tview
go/src/github.com/rivo/tview/util.go:56:2: undefined: runewidth.ZeroWidthJoiner

@vainkop commented on GitHub (Jan 14, 2021): ``` go get github.com/orisano/dlayer # github.com/rivo/tview go/src/github.com/rivo/tview/util.go:56:2: undefined: runewidth.ZeroWidthJoiner ```

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@rivo commented on GitHub (Jan 14, 2021):

I don't know why you're getting this. tview still uses v0.0.9 of go-runewidth, see here, which shouldn't result in this error. Make sure to use modules when importing tview.

@rivo commented on GitHub (Jan 14, 2021): I don't know why you're getting this. `tview` still uses v0.0.9 of `go-runewidth`, see [here](https://github.com/rivo/tview/blob/c818a0c789ee6b8327cf55de5415109181f63bcb/go.mod#L8), which shouldn't result in this error. Make sure to use modules when importing `tview`.

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@rivo commented on GitHub (Jan 17, 2021):

tcell was updated and this should be resolved with the latest commit now, too.

@rivo commented on GitHub (Jan 17, 2021): `tcell` was updated and this should be resolved with the latest commit now, too.

kerem commented

2026-03-04 01:04:40 +03:00

Author

Owner

@zemzale commented on GitHub (Jan 18, 2021):

Thanks!

@zemzale commented on GitHub (Jan 18, 2021): Thanks!