mirror of
https://github.com/rivo/tview.git
synced 2026-04-26 21:35:54 +03:00
[GH-ISSUE #519] Modal border background color no longer matches modal's background color #376
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tview#376
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @polothy on GitHub (Nov 2, 2020).
Original GitHub issue: https://github.com/rivo/tview/issues/519
The modal border background color used to match the background color of the modal itself. Now it appears that the border background color is the default background color.
I think this change introduced the new behavior:
github.com/rivo/tview@d551c850a7/box.go (L73)On the modal, the border is set on the
framewhich is private, so cannot workaround it by just updating the border style:github.com/rivo/tview@d551c850a7/modal.go (L49-L51)This PR could help to provide a way to implement a workaround: https://github.com/rivo/tview/pull/458 - but that's just an FYI. I of course do not mind how it is fixed or if it is actually implemented as intended and this is not a bug.
Since I'm making an issue, I'll take the opportunity to thank you for the amazing project! Been having a lot of fun using it 😄
@mevdschee commented on GitHub (Nov 4, 2020):
I have also seen this happen and I would appreciate a fix.
@polothy commented on GitHub (Nov 4, 2020):
You can see an example of the coloring in the presentation demo on the Flex and Grid demo pages.
@mevdschee commented on GitHub (Nov 4, 2020):
@polothy Thank you, I see exactly the same. And @rivo thank you for creating this wonderful library. I really like building stuff with it!
@rivo commented on GitHub (Mar 12, 2021):
The latest commit should fix this. Could you please give me feedback whether it works for you now?
(Sorry for the delay, btw.)
@mevdschee commented on GitHub (Mar 12, 2021):
Works on my machine! Latest on the left, older rev on the right (note the default dark-blue background behind the border).
Thank you.
Please keep up the good work on this fantastic library!
@rivo commented on GitHub (Mar 12, 2021):
More fixes. (Please refer to https://github.com/rivo/tview/issues/520#issuecomment-797659408.) Does it work for you with the latest update?
@mevdschee commented on GitHub (Mar 12, 2021):
I tried the "Hello world again" code (from ticket 520) and it failed previously, but works fine for me when upgraded from:
I hope this of use to you. Kind regards, Maurits
NB: I was able to reproduce the problem clearly by setting the default terminal background color to red (xfce4-terminal).
@rivo commented on GitHub (Mar 12, 2021):
Great! Thanks!