mirror of
https://github.com/rivo/tview.git
synced 2026-04-26 13:25:51 +03:00
[GH-ISSUE #460] merging derailed/tview fork? #330
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tview#330
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghostsquad on GitHub (Jun 13, 2020).
Original GitHub issue: https://github.com/rivo/tview/issues/460
I noticed that https://github.com/derailed/k9s, a very popular tool is using a fork of this repo (https://github.com/rivo/tview/compare/master...derailed:master?ts=4) (
115 commits ahead, 75 commits behind rivo:master.). I attempted to contact @derailed regarding whether the work they have done in their fork could be merged back into the official repo or not, but haven't received a response (email), and with no way to post an issue on their repo, here I am! I'm basically trying to figure out what I should be using for my own project, and what the overall health is of either.@rivo commented on GitHub (Jun 15, 2020):
I don't know all the forks out there and apart from a quick glance, I can't really comment on the fork you mentioned . Some changes they made look reasonable, others I probably wouldn't merge. I'm assuming that they needed changes/features quickly but because this repo doesn't progress very quickly, they decided to implement them in their own fork.
There are other forks out there that have added a lot of features (see #386 for a discussion). If you need those features and you're missing them here, it may be better to use that fork.
To me, simplicity, consistency, backwards compatibility, and few/no bugs is more important than adding all kinds of features which are only used by few people. Add to this the fact that I can only work on
tviewduring my free time, of which I don't have a lot. So it's slow.But I've said this before: I'm still working on it and plan on doing it for a long time. I don't want
tviewto become abandonware.I'd say, if the existing features work for you, this repo is your best bet. If you're missing a lot of stuff and need it quickly, you may want to look elsewhere.
@ghostsquad commented on GitHub (Jun 15, 2020):
❤️
Thank you! Ok, well I'm just getting started with all this, so this was just an initial "exploratory" concern. I'm happy to contribute to changes here. I prefer if features are added to the "primary" repo so that they can get the most benefit from the community. I'm likely not the best person to help you maintain, but if you need help, I'd love to help!
@rivo commented on GitHub (Jun 28, 2020):
Thanks. There are areas that need work but it would require longer discussions / exploration before any code is written. It's best not to just submit PRs (I don't have time to examine all the code that's been submitted to me) but instead to open an issue first to discuss the topic at hand. (Check out the contributing guide for details.)