starred/tview

Fork 0

mirror of https://github.com/rivo/tview.git synced 2026-04-27 05:45:49 +03:00

[GH-ISSUE #416] QueueUpdateDraw & Draw causes deadlock #306

New issue

Closed

opened 2026-03-04 01:03:47 +03:00 by kerem · 7 comments

kerem commented

2026-03-04 01:03:47 +03:00

Owner

Originally created by @tryffel on GitHub (Mar 7, 2020).
Original GitHub issue: https://github.com/rivo/tview/issues/416

I bisected the commit to fe30520.

I use it as such:

//goroutine1 (same as tview):
Application.Draw()

//goroutine2:
Application.QueueUpdateDraw(func() {...})

Both goroutines are now deadlocked at
application.go:524:

<- ch

Using go1.14 linux/amd64.

Originally created by @tryffel on GitHub (Mar 7, 2020). Original GitHub issue: https://github.com/rivo/tview/issues/416 I bisected the commit to [fe30520](https://github.com/rivo/tview/commit/fe3052019536251fd145835dbaa225b33b7d3088). I use it as such: ``` //goroutine1 (same as tview): Application.Draw() //goroutine2: Application.QueueUpdateDraw(func() {...}) ``` Both goroutines are now deadlocked at application.go:524: ``` <- ch ``` Using go1.14 linux/amd64.

kerem closed this issue

2026-03-04 01:03:48 +03:00

kerem commented

2026-03-04 01:03:48 +03:00

Author

Owner

@SoMuchForSubtlety commented on GitHub (Mar 8, 2020):

I noticed a similar issue.
Previously this worked

func main() {
	app := tview.NewApplication()
	text := tview.NewTextView()
	text.SetChangedFunc(func() { app.Draw() })
	app.SetRoot(text, true)
	fmt.Fprint(text, "text test")
	app.Run()
}

But now it deadlocks.

I also encountered the ChangedFunc app.Draw() locking when the application is running. I will try to reproduce it.

@SoMuchForSubtlety commented on GitHub (Mar 8, 2020): I noticed a similar issue. Previously this worked ```go func main() { app := tview.NewApplication() text := tview.NewTextView() text.SetChangedFunc(func() { app.Draw() }) app.SetRoot(text, true) fmt.Fprint(text, "text test") app.Run() } ``` But now it deadlocks. I also encountered the ChangedFunc `app.Draw()` locking when the application is running. I will try to reproduce it.

kerem commented

2026-03-04 01:03:48 +03:00

Author

Owner

@sarpdoruk commented on GitHub (Mar 10, 2020):

+1 on this.

Having app.Draw() in SetChangedFunc of textView makes whole app crash/freeze/unresponsive.

@sarpdoruk commented on GitHub (Mar 10, 2020): +1 on this. Having `app.Draw()` in `SetChangedFunc` of `textView` makes whole app crash/freeze/unresponsive.

kerem commented

2026-03-04 01:03:49 +03:00

Author

Owner

@rivo commented on GitHub (Apr 4, 2020):

The latest commit fixes the problem in @SoMuchForSubtlety's code but I'm not completely sure if your issues are also fixed. Please let me know so I can close this issue (again).

@rivo commented on GitHub (Apr 4, 2020): The latest commit fixes the problem in @SoMuchForSubtlety's code but I'm not completely sure if your issues are also fixed. Please let me know so I can close this issue (again).

kerem commented

2026-03-04 01:03:49 +03:00

Author

Owner

@tryffel commented on GitHub (May 6, 2020):

Yes it fixed this. Thanks =)

@tryffel commented on GitHub (May 6, 2020): Yes it fixed this. Thanks =)

kerem commented

2026-03-04 01:03:49 +03:00

Author

Owner

@miltalex commented on GitHub (Jun 18, 2020):

The issue persists. Using go1.14.1 darwin/amd64 and tview@fe953220389f

@miltalex commented on GitHub (Jun 18, 2020): The issue persists. Using go1.14.1 darwin/amd64 and tview@fe953220389f

kerem commented

2026-03-04 01:03:49 +03:00

Author

Owner

@rivo commented on GitHub (Aug 18, 2020):

Can you please paste some code that causes this deadlock?

@rivo commented on GitHub (Aug 18, 2020): Can you please paste some code that causes this deadlock?

kerem commented

2026-03-04 01:03:49 +03:00

Author

Owner

@rivo commented on GitHub (Jan 11, 2021):

Please open a new issue and reference this one if you want me to follow up on this topic.

@rivo commented on GitHub (Jan 11, 2021): Please open a new issue and reference this one if you want me to follow up on this topic.