[GH-ISSUE #290] Bug in AddDropDown(); will not initialize correctly #224

New issue

Closed

opened 2026-03-04 01:03:07 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:03:07 +03:00

Owner

Originally created by @mikeschinkel on GitHub (Jun 4, 2019).
Original GitHub issue: https://github.com/rivo/tview/issues/290

Currently in AddDropDown() you call SetCurrentOption(initialOption) before you call SetOptions(options, selected)) so the upshot is the parameter initialOption is ignored.

Here is the current code:

func (f *Form) AddDropDown(label string, options []string, initialOption int, selected func(option string, optionIndex int)) *Form {
	f.items = append(f.items, NewDropDown().
		SetLabel(label).
		SetCurrentOption(initialOption).
		SetOptions(options, selected))
	return f
}

Reversing the order resolves the issue:

func (f *Form) AddDropDown(label string, options []string, initialOption int, selected func(option string, optionIndex int)) *Form {
	f.items = append(f.items, NewDropDown().
		SetLabel(label).
		SetOptions(options, selected)).
		SetCurrentOption(initialOption)
	return f
}

I will submit a pull request.

Originally created by @mikeschinkel on GitHub (Jun 4, 2019). Original GitHub issue: https://github.com/rivo/tview/issues/290 Currently in `AddDropDown()` you call `SetCurrentOption(initialOption)` **before** you call `SetOptions(options, selected))` so the upshot is the parameter `initialOption` is ignored. Here is the current code: ``` func (f *Form) AddDropDown(label string, options []string, initialOption int, selected func(option string, optionIndex int)) *Form { f.items = append(f.items, NewDropDown(). SetLabel(label). SetCurrentOption(initialOption). SetOptions(options, selected)) return f } ``` Reversing the order resolves the issue: ``` func (f *Form) AddDropDown(label string, options []string, initialOption int, selected func(option string, optionIndex int)) *Form { f.items = append(f.items, NewDropDown(). SetLabel(label). SetOptions(options, selected)). SetCurrentOption(initialOption) return f } ``` I will submit a pull request.