starred/tview

Fork 0

mirror of https://github.com/rivo/tview.git synced 2026-04-27 05:45:49 +03:00

[GH-ISSUE #245] Method to get bottom-most scroll position possible, and getting TrackEnd for TextView #190

New issue

Closed

opened 2026-03-04 01:02:49 +03:00 by kerem · 7 comments

kerem commented

2026-03-04 01:02:49 +03:00

Owner

Originally created by @diamondburned on GitHub (Mar 1, 2019).
Original GitHub issue: https://github.com/rivo/tview/issues/245

I was looking to get the bottom-most scroll position and calculate scroll position in percentage, though as of now, there's no way to do this without calling ScrollToEnd(), but this means there will be visual changes.

By exposing the TrackEnd boolean, I could check that if it's false, show a toaster saying there's something updated.

By adding a method to get bottom scroll, I could calculate the scroll position of the buffer as a replacement for a scroll bar.

Originally created by @diamondburned on GitHub (Mar 1, 2019). Original GitHub issue: https://github.com/rivo/tview/issues/245 I was looking to get the bottom-most scroll position and calculate scroll position in percentage, though as of now, there's no way to do this without calling `ScrollToEnd()`, but this means there will be visual changes. By exposing the `TrackEnd` boolean, I could check that if it's false, show a toaster saying there's something updated. By adding a method to get bottom scroll, I could calculate the scroll position of the buffer as a replacement for a scroll bar.

kerem closed this issue

2026-03-04 01:02:49 +03:00

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@rivo commented on GitHub (Mar 9, 2019):

I'm sorry but I'm having trouble understanding what you're trying to achieve. I'm guessing here but do you want to find out if there are more lines beyond what is currently shown in a TextView?

Maybe you could include some kind of example or screenshot that illustrates your requirement.

@rivo commented on GitHub (Mar 9, 2019): I'm sorry but I'm having trouble understanding what you're trying to achieve. I'm guessing here but do you want to find out if there are more lines beyond what is currently shown in a `TextView`? Maybe you could include some kind of example or screenshot that illustrates your requirement.

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@diamondburned commented on GitHub (Mar 11, 2019):

I've actually found a way to get the bottom scroll in one of my forks, which is to check if TrackEnd is true, I could add height and currentScroll to get the bottom-most scroll. Then if the user scrolls up, I could calculate from that the total height of the buffer and give them their location.

As for getting TrackEnd, I would like to see, for example, if the user is looking at the bottom-most line of the buffer, which is where new information is printed. If they're scrolling, TrackEnd would be false, and they would be missing new information, thus I would notify them. This is, of course, a very specific use-case, but that's what is in my mind right now.

@diamondburned commented on GitHub (Mar 11, 2019): I've actually found a way to get the bottom scroll in one of my forks, which is to check if `TrackEnd` is true, I could add `height` and `currentScroll` to get the bottom-most scroll. Then if the user scrolls up, I could calculate from that the total height of the buffer and give them their location. As for getting TrackEnd, I would like to see, for example, if the user is looking at the bottom-most line of the buffer, which is where new information is printed. If they're scrolling, TrackEnd would be false, and they would be missing new information, thus I would notify them. This is, of course, a very specific use-case, but that's what is in my mind right now.

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@rivo commented on GitHub (Mar 16, 2019):

I could add a function that gives you information about what is visible at the moment. Something that tells you "the buffer currently has 42 lines, you are seeing lines 5 to 39 right now". Would that help you?

@rivo commented on GitHub (Mar 16, 2019): I could add a function that gives you information about what is visible at the moment. Something that tells you "the buffer currently has 42 lines, you are seeing lines 5 to 39 right now". Would that help you?

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@diamondburned commented on GitHub (Mar 17, 2019):

Well, I can already do that, but do tell me how the implementations will be, maybe it'll help.

@diamondburned commented on GitHub (Mar 17, 2019): Well, I can already do that, but do tell me how the implementations will be, maybe it'll help.

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@rivo commented on GitHub (Mar 17, 2019):

If you can already do that, then I don't know what you're still missing. You wrote

I would like to see, for example, if the user is looking at the bottom-most line of the buffer, which is where new information is printed.

to which my last answer would be a solution, I believe. But since you then wrote

I can already do that

I'm not sure if there is a problem anymore.

@rivo commented on GitHub (Mar 17, 2019): If you can already do that, then I don't know what you're still missing. You wrote > I would like to see, for example, if the user is looking at the bottom-most line of the buffer, which is where new information is printed. to which my last answer would be a solution, I believe. But since you then wrote > I can already do that I'm not sure if there is a problem anymore.

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@diamondburned commented on GitHub (Mar 19, 2019):

How would you implement that? If you would add it, that's fine for me.

@diamondburned commented on GitHub (Mar 19, 2019): How would you implement that? If you would add it, that's fine for me.

kerem commented

2026-03-04 01:02:50 +03:00

Author

Owner

@rivo commented on GitHub (May 13, 2019):

Apologies for the late reply. I was gone for a while. You'll need to determine it during the last call to Draw() here:

github.com/rivo/tview@7a653a04b3/textview.go (L829-L832)

If line < len(t.index) - 1, then there is still content after the fold.

I would probably save that info in the class and return it when needed.

@rivo commented on GitHub (May 13, 2019): Apologies for the late reply. I was gone for a while. You'll need to determine it during the last call to `Draw()` here: https://github.com/rivo/tview/blob/7a653a04b36c7fbc57aeb65923dc7f2f0d48b963/textview.go#L829-L832 If `line < len(t.index) - 1`, then there is still content after the fold. I would probably save that info in the class and return it when needed.

kerem referenced this issue

2026-03-04 01:08:20 +03:00

[PR #190] [MERGED] Fixed example code in presentation demo textview #872