starred/tview

Fork 0

mirror of https://github.com/rivo/tview.git synced 2026-04-26 13:25:51 +03:00

[GH-ISSUE #141] SetBorder hides contents of List and TextView #111

New issue

Closed

opened 2026-03-04 01:02:01 +03:00 by kerem · 5 comments

kerem commented

2026-03-04 01:02:01 +03:00

Owner

Originally created by @viktordanov on GitHub (Jul 21, 2018).
Original GitHub issue: https://github.com/rivo/tview/issues/141

When calling the SetBorder function on a List or a TextView (might be exhibited by other widgets too), no matter the argument, the contents of the targeted view get hidden and the view appears empty.

OS: Ubuntu 18.04
Shell: Bash 4.4.19

Originally created by @viktordanov on GitHub (Jul 21, 2018). Original GitHub issue: https://github.com/rivo/tview/issues/141 When calling the SetBorder function on a List or a TextView (might be exhibited by other widgets too), no matter the argument, the contents of the targeted view get hidden and the view appears empty. ``` OS: Ubuntu 18.04 Shell: Bash 4.4.19 ```

kerem closed this issue

2026-03-04 01:02:02 +03:00

kerem commented

2026-03-04 01:02:02 +03:00

Author

Owner

@rivo commented on GitHub (Jul 27, 2018):

I can't reproduce this. Can you send a short code snippet and a screenshot that illustrates this, please?

@rivo commented on GitHub (Jul 27, 2018): I can't reproduce this. Can you send a short code snippet and a screenshot that illustrates this, please?

kerem commented

2026-03-04 01:02:02 +03:00

Author

Owner

@viktordanov commented on GitHub (Jul 27, 2018):

Accourding to new observations, it appears that the issue is only present when the border is set using a chained .SetBorder function, which is most likely due to the output of the function. I appologize, if this is meant to function like this by design.

func main() {
	app = tview.NewApplication()

	textView2 := tview.NewTextView().SetText("2222222")
	textView2.SetBorder(true)

	mainView :=
		tview.NewFlex().SetDirection(tview.FlexColumn).
			AddItem(tview.NewTextView().SetText("sdsddas").SetBorder(true), 0, 4, false). // ISSUE PRESENT
			AddItem(textView2, 30, 2, false)                                              // ISSUE ABSENT

	if err := app.SetRoot(mainView, true).Run(); err != nil {
		panic(err)
	}
}

@viktordanov commented on GitHub (Jul 27, 2018): Accourding to new observations, it appears that the issue is only present when the border is set using a chained `.SetBorder` function, which is most likely due to the output of the function. I appologize, if this is meant to function like this by design. ``` func main() { app = tview.NewApplication() textView2 := tview.NewTextView().SetText("2222222") textView2.SetBorder(true) mainView := tview.NewFlex().SetDirection(tview.FlexColumn). AddItem(tview.NewTextView().SetText("sdsddas").SetBorder(true), 0, 4, false). // ISSUE PRESENT AddItem(textView2, 30, 2, false) // ISSUE ABSENT if err := app.SetRoot(mainView, true).Run(); err != nil { panic(err) } } ``` ![image](https://user-images.githubusercontent.com/7188510/43334198-5dfaad44-91d5-11e8-963d-b2ebc37ad87e.png)

kerem commented

2026-03-04 01:02:02 +03:00

Author

Owner

@rivo commented on GitHub (Jul 28, 2018):

I understand. Well, TextView inherits SetBorder() from Box and because SetBorder() returns a Box, if you assign the result to a variable, you have a Box on your hand, not a TextView:

iAmABox := tview.NewTextView().SetBorder(true)

This means that in your example, tview will call Box's Draw() function instead of TextView's Draw() function so it ends up empty.

I don't know of any way of changing the function's return value without duplicating all functions in the child classes. So at this point, the only thing you can do is this:

textView := tview.NewTextView()
textView.SetBorder(true)

@rivo commented on GitHub (Jul 28, 2018): I understand. Well, `TextView` inherits `SetBorder()` from `Box` and because `SetBorder()` returns a `Box`, if you assign the result to a variable, you have a `Box` on your hand, not a `TextView`: ```go iAmABox := tview.NewTextView().SetBorder(true) ``` This means that in your example, `tview` will call `Box`'s `Draw()` function instead of `TextView`'s `Draw()` function so it ends up empty. I don't know of any way of changing the function's return value without duplicating all functions in the child classes. So at this point, the only thing you can do is this: ```go textView := tview.NewTextView() textView.SetBorder(true) ```

kerem commented

2026-03-04 01:02:03 +03:00

Author

Owner

@viktordanov commented on GitHub (Jul 28, 2018):

I understand. Sacrificing good code structure for a little convenience is never worth it. Thanks for taking your time. 👍
Should I close this?

@viktordanov commented on GitHub (Jul 28, 2018): I understand. Sacrificing good code structure for a little convenience is never worth it. Thanks for taking your time. :+1: Should I close this?

kerem commented

2026-03-04 01:02:03 +03:00

Author

Owner

@rivo commented on GitHub (Aug 4, 2018):

I'll close it.

Not sure I'd say "never". I'm still wrestling with this decision because I tend to think that the convenience for the users (i.e. the developers who use tview) is more important. But it increases the boilerplate for every new primitive I introduce in the future, it duplicates a lot of code and documentation. And that's always a source for mistakes.

@rivo commented on GitHub (Aug 4, 2018): I'll close it. Not sure I'd say "never". I'm still wrestling with this decision because I tend to think that the convenience for the users (i.e. the developers who use `tview`) is more important. But it increases the boilerplate for every new primitive I introduce in the future, it duplicates a lot of code and documentation. And that's always a source for mistakes.