[PR #812] InsertColumn should increment lastColumn #1049

Open
opened 2026-03-04 01:09:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/812
Author: @jhorwitz75
Created: 2/12/2023
Status: 🔄 Open

Base: masterHead: fix-insert-column


📝 Commits (1)

  • ead28d0 increment lastColumn when inserting columns

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 table.go (+5 -0)

📄 Description

InsertColumn does not increment lastColumn, which causes the previous last column to be lost when redrawing the table. This PR verifies columns were actually added and then increments lastColumn.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/812 **Author:** [@jhorwitz75](https://github.com/jhorwitz75) **Created:** 2/12/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-insert-column` --- ### 📝 Commits (1) - [`ead28d0`](https://github.com/rivo/tview/commit/ead28d0e8f97808d00eb102ab0552c1e85d39c27) increment lastColumn when inserting columns ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `table.go` (+5 -0) </details> ### 📄 Description InsertColumn does not increment lastColumn, which causes the previous last column to be lost when redrawing the table. This PR verifies columns were actually added and then increments lastColumn. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tview#1049
No description provided.