[PR #643] [MERGED] go.mod: fix wrong reference to tcell dependency #1005

New issue

Closed

opened 2026-03-04 01:08:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:08:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/643
Author: @amorenoz
Created: 9/9/2021
Status: ✅ Merged
Merged: 9/9/2021
Merged by: @rivo

Base: master ← Head: fix_tcell_ref

📝 Commits (1)

6e31eb2 go.mod: fix wrong reference to tcell dependency

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 go.mod (+1 -1)

📄 Description

Last commit (github.com/rivo/tview@2f13f81dcb) made go.mod point to a tcell commit (github.com/gdamore/tcell@ae5116d728) that was not yet merged to master so it's not found by go get:

go get github.com/rivo/tview/
go get: github.com/rivo/tview@none updating to
	github.com/rivo/tview@v0.0.0-20210904173154-2f13f81dcb15 requires
	github.com/gdamore/tcell/v2@v2.4.1-0.20210904044819-ae5116d72813: invalid version: unknown revision ae5116d72813

The correct reference is github.com/gdamore/tcell@f057f0a857 IIUC

Signed-off-by: Adrian Moreno amorenoz@redhat.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/643 **Author:** [@amorenoz](https://github.com/amorenoz) **Created:** 9/9/2021 **Status:** ✅ Merged **Merged:** 9/9/2021 **Merged by:** [@rivo](https://github.com/rivo) **Base:** `master` ← **Head:** `fix_tcell_ref` --- ### 📝 Commits (1) - [`6e31eb2`](https://github.com/rivo/tview/commit/6e31eb2925ca4761c83b5633269151f72e88a8fe) go.mod: fix wrong reference to tcell dependency ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+1 -1) </details> ### 📄 Description Last commit (https://github.com/rivo/tview/commit/2f13f81dcb15c36a8b3493bb570b0963cfd55d4b) made go.mod point to a tcell commit (https://github.com/gdamore/tcell/commit/ae5116d728135b1a9c0d0d888bd1b6624e726853) that was not yet merged to master so it's not found by `go get`: ``` go get github.com/rivo/tview/ go get: github.com/rivo/tview@none updating to github.com/rivo/tview@v0.0.0-20210904173154-2f13f81dcb15 requires github.com/gdamore/tcell/v2@v2.4.1-0.20210904044819-ae5116d72813: invalid version: unknown revision ae5116d72813 ``` The correct reference is https://github.com/gdamore/tcell/commit/f057f0a857a1b3ac3e4fff8c6cfe8126f8387cd1 IIUC Signed-off-by: Adrian Moreno <amorenoz@redhat.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>