mirror of
https://github.com/agrinman/tunnelto.git
synced 2026-04-26 09:16:03 +03:00
[GH-ISSUE #1] tunnelto.dev subdomains not working #93
Labels
No labels
Need more info
bug
duplicate
enhancement
good first issue
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tunnelto#93
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stealthybox on GitHub (Apr 22, 2020).
Original GitHub issue: https://github.com/agrinman/tunnelto/issues/1
Hi, cool project!
I was playing with it and instantly noticed the subdomain flag.
Are subdomains supposed to work on the public instance?
Do I need to configure an API key for that to work?
I expected this command to give me back a public URL similar to
stealthybox.tunnelto.devorstealthybox-aexsh3w5.tuneelto.dev, but instead, the-soption seems ignored.Did I misunderstand that this is supposed to only be an overriden host-header that's passed into the proxied request?
If not and I'm understanding this feature correctly, we can probably implement an error or warning message and include some docs around API keys or the capabilities of private instances.
@agrinman commented on GitHub (Apr 22, 2020):
Hi @stealthybox, this is currently by design (though you're right that a helpful error message is needed). For the publicly hosted version, we're currently only allowing random subdomains. If you deploy it yourself, this is controlled by enabling a secret key as noted in the readme.
I like the idea of adding random characters to a specified subdomain though -- we can definitely support that in the publicly hosted deployment!
@agrinman commented on GitHub (Apr 25, 2020):
Fixed in
github.com/agrinman/wormhole@eb4fb89d5c@stealthybox commented on GitHub (May 19, 2020):
nice! thanks!