[PR #475] [MERGED] Fix filesize display in file viewer #989

Closed
opened 2026-03-02 16:02:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/prasathmani/tinyfilemanager/pull/475
Author: @badcf00d
Created: 12/22/2020
Status: Merged
Merged: 12/23/2020
Merged by: @prasathmani

Base: masterHead: patch-1


📝 Commits (1)

  • 5cb9a95 Fix file size display in file viewer

📊 Changes

1 file changed (+3 additions, -4 deletions)

View changed files

📝 tinyfilemanager.php (+3 -4)

📄 Description

The existing page seems to always display the file size as bytes "B" even if it was supposed to show megabytes or kilobytes etc. It also seemed to have a problem with greater than 32 bit file sizes that would wrap around to show the file size as negative a billion bytes or something.

Mainly just copied the implementation from the folder view into the file info view.

Thanks,
Peter


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/prasathmani/tinyfilemanager/pull/475 **Author:** [@badcf00d](https://github.com/badcf00d) **Created:** 12/22/2020 **Status:** ✅ Merged **Merged:** 12/23/2020 **Merged by:** [@prasathmani](https://github.com/prasathmani) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`5cb9a95`](https://github.com/prasathmani/tinyfilemanager/commit/5cb9a956827e113dc5014e601a5aea0024c50fc7) Fix file size display in file viewer ### 📊 Changes **1 file changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tinyfilemanager.php` (+3 -4) </details> ### 📄 Description The existing page seems to always display the file size as bytes "B" even if it was supposed to show megabytes or kilobytes etc. It also seemed to have a problem with greater than 32 bit file sizes that would wrap around to show the file size as negative a billion bytes or something. Mainly just copied the implementation from the folder view into the file info view. Thanks, Peter --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 16:02:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tinyfilemanager#989
No description provided.