[PR #23] [MERGED] Update tinyfilemanager.php #881

New issue

Closed

opened 2026-03-02 16:02:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 16:02:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/prasathmani/tinyfilemanager/pull/23
Author: @alecos71
Created: 11/6/2017
Status: ✅ Merged
Merged: 11/6/2017
Merged by: @prasathmani

Base: master ← Head: patch-6

📝 Commits (2)

be1288a Update tinyfilemanager.php
287146d Update tinyfilemanager.php

📊 Changes

1 file changed (+55 additions, -8 deletions)

View changed files

📝 tinyfilemanager.php (+55 -8)

📄 Description

This change solves several bug:

FM_EDIT_FILE constant not defined, I added to solve this line:

define('FM_EDIT_FILE', $edit_files);

Html Validation issue: acion="" cannot be empty. I replaced all action="" with:

action="<?php echo htmlspecialchars($_SERVER['PHP_SELF']); ?>"

Login Form contains a lot of HTML + PHP + JS not used and then produces php notice. I solved adding two news header and footer login which are basic HTML + CSS

fm_show_header_login();

and

fm_show_footer_login();

This solves several issue due to unused HTML + PHP + JS elements.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/prasathmani/tinyfilemanager/pull/23 **Author:** [@alecos71](https://github.com/alecos71) **Created:** 11/6/2017 **Status:** ✅ Merged **Merged:** 11/6/2017 **Merged by:** [@prasathmani](https://github.com/prasathmani) **Base:** `master` ← **Head:** `patch-6` --- ### 📝 Commits (2) - [`be1288a`](https://github.com/prasathmani/tinyfilemanager/commit/be1288ac60d7d0a93c1c60c32d078d7c4bdc84aa) Update tinyfilemanager.php - [`287146d`](https://github.com/prasathmani/tinyfilemanager/commit/287146d8afaba460ca0c131d966fc724cda840aa) Update tinyfilemanager.php ### 📊 Changes **1 file changed** (+55 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `tinyfilemanager.php` (+55 -8) </details> ### 📄 Description This change solves several bug: 1) FM_EDIT_FILE constant not defined, I added to solve this line: define('FM_EDIT_FILE', $edit_files); 2) Html Validation issue: acion="" cannot be empty. I replaced all action="" with: action="<?php echo htmlspecialchars($_SERVER['PHP_SELF']); ?>" 3) Login Form contains a lot of HTML + PHP + JS not used and then produces php notice. I solved adding two news header and footer login which are basic HTML + CSS fm_show_header_login(); and fm_show_footer_login(); This solves several issue due to unused HTML + PHP + JS elements. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>