[GH-ISSUE #1136] Full size error #733

Open
opened 2026-03-02 16:01:05 +03:00 by kerem · 7 comments
Owner

Originally created by @acastrovargas on GitHub (Jan 15, 2024).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/1136

The full size is not real, it only shows the value of files and not the contents in the folders.

CinNg8j

Originally created by @acastrovargas on GitHub (Jan 15, 2024). Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/1136 The full size is not real, it only shows the value of files and not the contents in the folders. ![CinNg8j](https://github.com/prasathmani/tinyfilemanager/assets/30557965/f9e6ea93-e2c2-4b67-bece-65d8b58e95d3)
Author
Owner

@explorerfaketimepass commented on GitHub (Jan 24, 2024):

#1100 Check out this PR, as it implements a feature to display disk space usage.

<!-- gh-comment-id:1908448805 --> @explorerfaketimepass commented on GitHub (Jan 24, 2024): #1100 Check out this PR, as it implements a feature to display disk space usage.
Author
Owner

@acastrovargas commented on GitHub (Jan 24, 2024):

The PR is still not integrated?

<!-- gh-comment-id:1908583166 --> @acastrovargas commented on GitHub (Jan 24, 2024): The PR is still not integrated?
Author
Owner

@ner00 commented on GitHub (Jan 24, 2024):

Just note that the script will have to iterate through every sub-folder and its contents to calculate this, every time the page refreshes. I had implemented this on a custom version of mine but had to turn if off due to the performance impact. If you have few files and all with a certain acceptable size, no problem, otherwise the HDD will be taxed immensely.

<!-- gh-comment-id:1908697049 --> @ner00 commented on GitHub (Jan 24, 2024): Just note that the script will have to iterate through every sub-folder and its contents to calculate this, every time the page refreshes. I had implemented this on a custom version of mine but had to turn if off due to the performance impact. If you have few files and all with a certain acceptable size, no problem, otherwise the HDD will be taxed immensely.
Author
Owner

@acastrovargas commented on GitHub (Jan 24, 2024):

Thanks, I was about to implement, for this reason I will not do it

<!-- gh-comment-id:1908702055 --> @acastrovargas commented on GitHub (Jan 24, 2024): Thanks, I was about to implement, for this reason I will not do it
Author
Owner

@hppanpaliya commented on GitHub (Jan 24, 2024):

@ner00 No, the script does not iterate through every sub-folder and its contents to calculate disk space. It uses efficient built-in PHP functions (disk_total_space() and disk_free_space()) that directly query the operating system, so it won't heavily tax the HDD.

<!-- gh-comment-id:1908703767 --> @hppanpaliya commented on GitHub (Jan 24, 2024): @ner00 No, the script does not iterate through every sub-folder and its contents to calculate disk space. It uses efficient built-in PHP functions (disk_total_space() and disk_free_space()) that directly query the operating system, so it won't heavily tax the HDD.
Author
Owner

@ner00 commented on GitHub (Jan 24, 2024):

@hppanpaliya my misunderstanding then, I was thinking of folder file size, which is obviously different and that does have to work in the way I described.

<!-- gh-comment-id:1908705392 --> @ner00 commented on GitHub (Jan 24, 2024): @hppanpaliya my misunderstanding then, I was thinking of folder ~file~ size, which is obviously different and that does have to work in the way I described.
Author
Owner

@acastrovargas commented on GitHub (Jan 24, 2024):

<!-- gh-comment-id:1908740118 --> @acastrovargas commented on GitHub (Jan 24, 2024): <a href="https://imgur.com/HNjbCs8.png"> <img src="https://imgur.com/HNjbCs8.png" /> </a>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tinyfilemanager#733
No description provided.