[GH-ISSUE #903] Rename doesn't work #594

Closed
opened 2026-03-02 16:00:06 +03:00 by kerem · 3 comments
Owner

Originally created by @RenHoekNL on GitHub (Nov 30, 2022).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/903

Expected result: A window pops up allowing you to change a name

Actual result: You click the button and nothing pops up. No errors in the JS console even.

Tried in the most recent Firefox and Chrome. Renaming even doesn't work on the demo page (https://tinyfilemanager.github.io/demo/)

Originally created by @RenHoekNL on GitHub (Nov 30, 2022). Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/903 Expected result: A window pops up allowing you to change a name Actual result: You click the button and nothing pops up. No errors in the JS console even. Tried in the most recent Firefox and Chrome. Renaming even doesn't work on the demo page (https://tinyfilemanager.github.io/demo/)
kerem closed this issue 2026-03-02 16:00:06 +03:00
Author
Owner

@smalos commented on GitHub (Dec 1, 2022):

No renaming issues here with PHP version: 8.0.6
Do you see any errors in the server logs?

<!-- gh-comment-id:1333397099 --> @smalos commented on GitHub (Dec 1, 2022): No renaming issues here with PHP version: 8.0.6 Do you see any errors in the server logs?
Author
Owner

@jackyhuynh0407 commented on GitHub (Dec 1, 2022):

I got the same issue. But I found that only folder and file on root can't rename. On sub folder rename is work.

<!-- gh-comment-id:1333471677 --> @jackyhuynh0407 commented on GitHub (Dec 1, 2022): I got the same issue. But I found that only folder and file on root can't rename. On sub folder rename is work.
Author
Owner

@smalos commented on GitHub (Dec 1, 2022):

Comparing an older version with the latest, there was a change in the JavaScript function rename() :

In the root folder, an empty argument e is passed and the added check prevents the rename dialog form popping up:
if(e && t)

<!-- gh-comment-id:1333682382 --> @smalos commented on GitHub (Dec 1, 2022): Comparing an older version with the latest, there was a change in the JavaScript function rename() : In the root folder, an empty argument e is passed and the added check prevents the rename dialog form popping up: `if(e && t)`
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tinyfilemanager#594
No description provided.