mirror of
https://github.com/prasathmani/tinyfilemanager.git
synced 2026-04-26 19:05:54 +03:00
[GH-ISSUE #553] Disable / Hide destructive actions when use_auth is false. #398
Labels
No labels
Feature
Feature
Is It Really an Issue?
Need More Info
Request
Security
bug
duplicate
enhancement
enhancement
help wanted
invalid
pull-request
question
suggestion
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tinyfilemanager#398
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @17500mph on GitHub (May 20, 2021).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/553
Seems like TFM was showing only the three non-destructuve Actions when in $user mode or in use_auth=false.
Now I see three action icons (Preview, permalink and download) plus three placeholders that still allow access to the Delete, Rename, and, Copy to.. actions:
In screenshot: Upper vs. Lower, and see the 'delete' tool tip visible?
Ideally, I'd like to be able to login as admin but if no login, it functions as if $use_auth = false.
I don't need the login option even visible. If I use the URL, then it lets me. Otherwise it's just read only. Right now the only way I can think to do that is use two separate instances of TFM, where the URL to the one that can be logged into for admin is unpublished. Which isn't that horrible actually. But right now, the destructive Actions are still working .. and I would rather them not be. :)
@17500mph commented on GitHub (Jun 12, 2021):
Also, want to make sure that even if the user knows the URL for a destructive function that it does not accept it if auth is false. Probably already does, but just in case it has not been tried.
...and I just tried. It does let me delete as it's still showing me the link content in the lower left of the browser as it does.
@17500mph commented on GitHub (Jun 13, 2021):
To replicate this use the script with $auth=true, sign in as user and then change $auth to false.