[GH-ISSUE #351] settings not updating #258

Closed
opened 2026-03-02 15:57:16 +03:00 by kerem · 7 comments
Owner

Originally created by @mitle on GitHub (Apr 29, 2020).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/351

when saving settings, the old configuration is shown again after pressing the button. Page refresh is needed to show the new settings.

Originally created by @mitle on GitHub (Apr 29, 2020). Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/351 when saving settings, the old configuration is shown again after pressing the button. Page refresh is needed to show the new settings.
kerem 2026-03-02 15:57:16 +03:00
Author
Owner

@prasathmani commented on GitHub (May 4, 2020):

is your server is running in WSL. plz provide more details about your OS, PHP Version

<!-- gh-comment-id:623355138 --> @prasathmani commented on GitHub (May 4, 2020): is your server is running in WSL. plz provide more details about your OS, PHP Version
Author
Owner

@ghost commented on GitHub (May 27, 2020):

Hi,
Same issue here

OS:
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"

PHP:
PHP 7.4.6 (cli) (built: May 14 2020 10:02:31) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.6, Copyright (c), by Zend Technologies

2020-05-27_19h09_23

Go to Settings, change language, click on save, page is reloading but without any change. Same with any option.

2020-05-27_19h09_36

There is no error in Apache logs. Access logs :

X.X.X.X - - [27/May/2020:19:09:37 +0200] "POST /tinyfilemanager.php?p=&settings=1 HTTP/1.1" 200 2165 "https://files.domain.com/tinyfilemanager.php?p=&settings=1" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36"
X.X.X.X - - [27/May/2020:19:09:37 +0200] "GET /tinyfilemanager.php?p=&settings=1 HTTP/1.1" 200 12417 "https://files.domain.com/tinyfilemanager.php?p=&settings=1" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36"
<!-- gh-comment-id:634810881 --> @ghost commented on GitHub (May 27, 2020): Hi, Same issue here OS: PRETTY_NAME="Debian GNU/Linux 9 (stretch)" NAME="Debian GNU/Linux" VERSION_ID="9" VERSION="9 (stretch)" PHP: PHP 7.4.6 (cli) (built: May 14 2020 10:02:31) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.6, Copyright (c), by Zend Technologies ![2020-05-27_19h09_23](https://user-images.githubusercontent.com/20670942/83051054-beaa9e00-a04d-11ea-9e4f-282930ca3356.png) Go to Settings, change language, click on save, page is reloading but without any change. Same with any option. ![2020-05-27_19h09_36](https://user-images.githubusercontent.com/20670942/83051074-c36f5200-a04d-11ea-8e63-fe7473cafd3f.png) There is no error in Apache logs. Access logs : ``` X.X.X.X - - [27/May/2020:19:09:37 +0200] "POST /tinyfilemanager.php?p=&settings=1 HTTP/1.1" 200 2165 "https://files.domain.com/tinyfilemanager.php?p=&settings=1" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36" X.X.X.X - - [27/May/2020:19:09:37 +0200] "GET /tinyfilemanager.php?p=&settings=1 HTTP/1.1" 200 12417 "https://files.domain.com/tinyfilemanager.php?p=&settings=1" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36" ```
Author
Owner

@rems28 commented on GitHub (Jun 7, 2020):

Hi, I have the same problem. My OS is Debian 10 with php-7.3 provided by the distro. I can make effects to the setting I choose when I click only one setting to change and make the saving operation several times (+/- 3 times works for me). You've make a great job, guys, thanks for that.

<!-- gh-comment-id:640231554 --> @rems28 commented on GitHub (Jun 7, 2020): Hi, I have the same problem. My OS is Debian 10 with php-7.3 provided by the distro. I can make effects to the setting I choose when I click only one setting to change and make the saving operation several times (+/- 3 times works for me). You've make a great job, guys, thanks for that.
Author
Owner

@zwozwo commented on GitHub (Jun 26, 2020):

I had the same problem, but really it works when you press the button three times. Thank you rems28 and thank you as well prasathmani for this script!

<!-- gh-comment-id:650198303 --> @zwozwo commented on GitHub (Jun 26, 2020): I had the same problem, but really it works when you press the button three times. Thank you rems28 and thank you as well prasathmani for this script!
Author
Owner

@rene-hermenau commented on GitHub (Nov 5, 2020):

@prasathmani May I recommend changing the color for the active button state to green?

It's absolutely not possible to see at a glance if the button is active or disabled which is not so good for usability;-)
Thanks to my friend @alaasalama for catching this. Opened an issue for this: https://github.com/prasathmani/tinyfilemanager/issues/446

<!-- gh-comment-id:722245822 --> @rene-hermenau commented on GitHub (Nov 5, 2020): @prasathmani May I recommend changing the color for the active button state to green? It's absolutely not possible to see at a glance if the button is active or disabled which is not so good for usability;-) Thanks to my friend @alaasalama for catching this. Opened an issue for this: https://github.com/prasathmani/tinyfilemanager/issues/446
Author
Owner

@je2555 commented on GitHub (Jul 29, 2021):

As a note to anyone else who might stumble onto this issue, you can't change any settings in the web interface if you define the $CONFIG array in config.php

So if you set a default language or some of the other options you can no longer modify them without modifying config.php

These seem to be the defaults if you don't define the array:

$CONFIG = '{"lang":"en","error_reporting":false,"show_hidden":true,"hide_Cols":false,"calc_folder":true}';
<!-- gh-comment-id:889053090 --> @je2555 commented on GitHub (Jul 29, 2021): As a note to anyone else who might stumble onto this issue, you can't change any settings in the web interface if you define the `$CONFIG` array in `config.php` So if you set a default language or some of the other options you can no longer modify them without modifying `config.php` These seem to be the defaults if you don't define the array: ```php $CONFIG = '{"lang":"en","error_reporting":false,"show_hidden":true,"hide_Cols":false,"calc_folder":true}'; ```
Author
Owner

@someone42 commented on GitHub (Jul 15, 2022):

I have also encountered this issue, I am using Raspbian GNU/Linux 10 (buster) with php-7.3. After some experimentation, I believe that on some systems, Zend OPcache doesn't realise that tinyfilemanager.php has been modified and when the settings page is immediately reloaded after pressing the Save button, PHP will use the old cached version of tinyfilemanager.php with the old settings.

Here are some workarounds:

  1. Disable Zend OPcache. This has a negative impact on performance.
  2. Introduce a few seconds delay in reloading the settings page whenever the Save button is pressed. I can submit a PR for this if people are interested.
<!-- gh-comment-id:1185483120 --> @someone42 commented on GitHub (Jul 15, 2022): I have also encountered this issue, I am using Raspbian GNU/Linux 10 (buster) with php-7.3. After some experimentation, I believe that on some systems, Zend OPcache doesn't realise that tinyfilemanager.php has been modified and when the settings page is immediately reloaded after pressing the Save button, PHP will use the old cached version of tinyfilemanager.php with the old settings. Here are some workarounds: 1. Disable Zend OPcache. This has a negative impact on performance. 2. Introduce a few seconds delay in reloading the settings page whenever the Save button is pressed. I can submit a PR for this if people are interested.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tinyfilemanager#258
No description provided.