mirror of
https://github.com/prasathmani/tinyfilemanager.git
synced 2026-04-27 19:35:58 +03:00
[GH-ISSUE #199] Feature req: external configuration file #141
Labels
No labels
Feature
Feature
Is It Really an Issue?
Need More Info
Request
Security
bug
duplicate
enhancement
enhancement
help wanted
invalid
pull-request
question
suggestion
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tinyfilemanager#141
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheFax on GitHub (Jul 24, 2019).
Original GitHub issue: https://github.com/prasathmani/tinyfilemanager/issues/199
Feature request
Add the possibility to use an external configuration file.
For example, at every new version, I must edit your PHP file in order to set my own usename and password and the $root_path.
My proposal is to add an include or something similar, like this:
tinyfilemanager.php
h3k_config.php
So, if customer want, he can put a file 'h3k_config.php' in the same directory of 'tinyfilemanager.php' and can avoid to edit your original script everytime you upload a new version.
@joglomedia commented on GitHub (Nov 26, 2019):
@TheFax may be this is what you need?
https://github.com/PHPlayground/tinyfilemanager/tree/lemperfm_1.3.0
@TheFax commented on GitHub (Apr 3, 2020):
@joglomedia
Your solution is probably the most professional.
But I see two issues:
Your branch is not updated; (your code is version 2.3.8, version of prasathmani is obviously more recent, ).
So, the main reason for my proposal was to make upgrade of TiniFileManager easier. And if I use your branch it actually not upgraded at all.
TinyFileManager should be a
In your solution the presence of folder
config/is mandatory and it adds more file to the base code. This sounds bad in a project like this. In my solution, the config file is completely optional and if somebody want to keep its TinyFileManager as a single file app, it is free to do so. In fact the first line of this thread is "Add the possibility to use an external configuration file." and my code allows the possibility that the configuration file is absent.Can we work together in order to find a real solution?
@joglomedia commented on GitHub (Apr 7, 2020):
@TheFax
I think this is the easiest one for "optional" external configuration using my branch, if we add the custom configuration as below (just example):
Those codes give more flexibility, the config folder which contain custom configurations is optional and could be excluded from TFM master branch, user can create it as needed. When there is no custom configuration, the default one still persist.
How about this idea @prasathmani ?
@D0tty commented on GitHub (May 3, 2020):
If I may add, this feature would be very nice to have a docker container that runs with our credentials with only one file needed to configure it
@prasathmani commented on GitHub (May 24, 2020):
external configuration file added in latest version