[PR #942] [MERGED] Bug fix: Delete confirm dialog will work wrong aflter cancel. #1094

Closed
opened 2026-03-02 16:03:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/prasathmani/tinyfilemanager/pull/942
Author: @fbotp
Created: 1/18/2023
Status: Merged
Merged: 1/19/2023
Merged by: @prasathmani

Base: masterHead: master


📝 Commits (2)

  • d9febe9 Bug fix: Only delete first file/directory when clicking the delete button multiple times and canceling.
  • 0c20e47 Add variable name for delete dialog

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 tinyfilemanager.php (+3 -1)

📄 Description

Clicking and canceling the delete confirm dialog will cause the information when the last confirmation of deletion is the file/directory information of the first click on the delete button.
Example on Demo:
屏幕录制2023-01-18-09 23 43


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/prasathmani/tinyfilemanager/pull/942 **Author:** [@fbotp](https://github.com/fbotp) **Created:** 1/18/2023 **Status:** ✅ Merged **Merged:** 1/19/2023 **Merged by:** [@prasathmani](https://github.com/prasathmani) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`d9febe9`](https://github.com/prasathmani/tinyfilemanager/commit/d9febe9b5718adf7d53914e50ec9c77aea9ff87b) Bug fix: Only delete first file/directory when clicking the delete button multiple times and canceling. - [`0c20e47`](https://github.com/prasathmani/tinyfilemanager/commit/0c20e47d4422253223b49e4f802d1b75547d9fa7) Add variable name for delete dialog ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tinyfilemanager.php` (+3 -1) </details> ### 📄 Description Clicking and canceling the delete confirm dialog will cause the information when the last confirmation of deletion is the file/directory information of the first click on the delete button. Example on [Demo](https://tinyfilemanager.github.io/demo/): ![屏幕录制2023-01-18-09 23 43](https://user-images.githubusercontent.com/46618620/213062758-483f8772-8ef2-4b80-aea1-791fdd7d501b.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 16:03:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tinyfilemanager#1094
No description provided.