[PR #848] [MERGED] Removes some php ext installs as they are already installed in base #1072

New issue

Closed

opened 2026-03-02 16:03:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 16:03:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/prasathmani/tinyfilemanager/pull/848
Author: @efremovd
Created: 8/30/2022
Status: ✅ Merged
Merged: 8/31/2022
Merged by: @prasathmani

Base: master ← Head: update-pipeline

📝 Commits (1)

3a5060c Removes php ext installs as their are already installed in base

📊 Changes

1 file changed (+1 additions, -4 deletions)

View changed files

📝 Dockerfile (+1 -4)

📄 Description

Hi,

In the #845 I mentioned that docker builds seem like fails. Issue is with building iconv lib. I've looked around and it seems this modules are already installed in base image and there is no need to add them again.

Here is an output

$ docker run php:7.4-cli-alpine -m 
[PHP Modules]
Core
ctype
curl
date
dom
fileinfo
filter
ftp
hash
iconv
json
libxml
mbstring
mysqlnd
openssl
pcre
PDO
pdo_sqlite
Phar
posix
readline
Reflection
session
SimpleXML
sodium
SPL
sqlite3
standard
tokenizer
xml
xmlreader
xmlwriter
zlib

[Zend Modules]

So in this PR I've removed:

iconv
mbstring
fileinfo

as they are already present in base image.

This PR is also closes #845

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/prasathmani/tinyfilemanager/pull/848 **Author:** [@efremovd](https://github.com/efremovd) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 8/31/2022 **Merged by:** [@prasathmani](https://github.com/prasathmani) **Base:** `master` ← **Head:** `update-pipeline` --- ### 📝 Commits (1) - [`3a5060c`](https://github.com/prasathmani/tinyfilemanager/commit/3a5060cfde48cdd387a2552195f38624b3aaa442) Removes php ext installs as their are already installed in base ### 📊 Changes **1 file changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -4) </details> ### 📄 Description Hi, In the #845 I mentioned that docker builds seem like fails. Issue is with building iconv lib. I've looked around and it seems this modules are already installed in base image and there is no need to add them again. Here is an output ``` $ docker run php:7.4-cli-alpine -m [PHP Modules] Core ctype curl date dom fileinfo filter ftp hash iconv json libxml mbstring mysqlnd openssl pcre PDO pdo_sqlite Phar posix readline Reflection session SimpleXML sodium SPL sqlite3 standard tokenizer xml xmlreader xmlwriter zlib [Zend Modules] ``` So in this PR I've removed: * iconv * mbstring * fileinfo as they are already present in base image. This PR is also closes #845 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>